330299 - remember password in keychain dialog has no accelerator (shortcut) for don't remember

Status: RESOLVED FIXED

(Camino Graveyard :: Accessibility, defect)

Description

[timeless]

I'm not going to press <esc> because there are three buttons and while I know <enter> will trigger the active button (remember), that still leaves two buttons and i can't predict which will be chosen by cancel.

I expect cmd-d to be "don't remember".

Comment 1

[Mike Pinkerton (not reading bugmail)]

this bugs me as well.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

FIXED by the checkin for bug 328048 (it's cmd-N now since the button name changed).

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Oops, wrong button; sorry.  "Don't" is still only Esc.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

1.2 until we know how to assign multiple key equivalents to buttons

Comment 5

[jm3]

this used to work in FF 1.5 ('r' was the key accelerator for 'remember')

Comment 6

[Chris Lawson (gone)]

(In reply to comment #5)
> this used to work in FF 1.5 ('r' was the key accelerator for 'remember')

This bug is for Camino, which uses a different UI from Firefox. If this is a problem in Firefox, that needs to be filed as a separate bug.

cl

Comment 8

[Chris Lawson (gone)]

Tweaking summary to catch more dupes.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mass un-setting milestone per 1.6 roadmap.

Filter on RemoveRedonkulousBuglist to remove bugspam.

Developers: if you have a patch in hand for one of these bugs, you may pull the bug back to 1.6 *at that point*.

Comment 10

[Mark Mentovai]

NSAlert sucks.  You can pass it an NSString and can then get at the NSButtons it creates, but you can't pass it NSButtons directly.

We could do an NSButton subclass with poseAsClass, but that's kind of evil.

We can't do anything with the buttons array from -[NSAlert buttons], it's immutable (it's not just casted to NSArray*, it actually doesn't support replacement).

We can maybe attack this by hooking something up to the window by calling -[NSAlert window].

Comment 11

[Mark Mentovai]

Attachment: Use a fake key-equivalent-processing view

Like so.  This adds command-D to the "Don't Store" button, in addition to the existing Esc.

Comment 12

[Mark Mentovai]

Comment on attachment 292657 [details] [diff] [review]
Use a fake key-equivalent-processing view

Actually, I'll change |object| and |selector| to |target| and |action|, to match the names used by NSActionCell.  That means that you can operate on a KeyEquivView using the same selectors as an NSButtonCell, which is the right thing because NSButtonCell is the workhorse for NSButton, which KeyEquivView is intended to be an invisible variant of.

Comment 13

[Stuart Morgan]

Comment on attachment 292657 [details] [diff] [review]
Use a fake key-equivalent-processing view

Cute; r=me

>+    if ((modifier & NSDeviceIndependentModifierFlagsMask) == mModifiers &&
>+      [character isEqualToString:mKeyEquivalent]) {

Camino style here is:

      if ((modifier & NSDeviceIndependentModifierFlagsMask) == mModifiers &&
          [character isEqualToString:mKeyEquivalent])
        {

Comment 14

[Mark Mentovai]

Checked in on the trunk and MOZILLA_1_8_BRANCH for Camino 1.6b1.