330511 - Plug-in blocklisting

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[Robert Strong (they/them - no direct email)]

Tracking bug for plug-in blocklisting. This is an offshoot from bug 271166 which covers blocklisting of Extension Manager managed addons.

Comment 1

[Doron Rosenberg (IBM)]

How are we planning on figure which plugin to block? Plugin name wouldn't work probably, dll names?

Comment 2

[Robert Strong (they/them - no direct email)]

Plug-in name and / or file name along with version... jst has a better handle on that than I do.

Comment 3

[Jesse Ruderman]

Dup of bug 271559?

Comment 4

[Michael Wu [:mwu]]

Using this bug for adding the backend changes and bug 271559 as the tracking bug.

Comment 5

[Michael Wu [:mwu]]

Attachment: Add plugins blocklisting support, v1

Not very well tested yet but I'm pretty sure this is close to what I want to do. Will put together a frontend for testing soon.

Comment 6

[Michael Wu [:mwu]]

Attachment: Add plugins blocklisting support, v2

Tested and (this one) seems to work. Some notes on the behavior:

1. Setting blocklisted to true will automatically disable the plugin, but it will not stop any currently running instances of the plugin. Setting disabled to true, however, will immediately stop all instances of the disabled plugin.
2. Setting blocklisted to false will not reenable the plugin.
3. Even if a plugin is blocklisted, it can be reenabled. (although the frontend doesn't allow this yet..)

Still a work in progress.. need to write a patch to test the blocklisting notification.

Comment 7

[Michael Wu [:mwu]]

Comment on attachment 271169 [details] [diff] [review]
Add plugins blocklisting support, v2

Tested everything and it seems to work.

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 271169 [details] [diff] [review]
Add plugins blocklisting support, v2

- In nsPluginHostImpl::IsPluginEnabledForType(const char* aMimeType):

-  if (!mJavaEnabled && IsJavaMIMEType(aMimeType)) {
-    // Return DISABLED whether we have a java plugin or not -- if it's
-    // disabled, it's disabled.
-    return NS_ERROR_PLUGIN_DISABLED;
-  }

You're moving this code to give the block listing priority over whether a plugin is disabled or not. Don't we want to keep it the other way around? I.e. if I disable java, I don't care whether it is or gets blocklisted, I don't want to see any UI for it or anything, I would think.

r+sr=jst with that taken into consideration.

Comment 9

[Michael Wu [:mwu]]

(In reply to comment #8)
> You're moving this code to give the block listing priority over whether a
> plugin is disabled or not. Don't we want to keep it the other way around? I.e.
> if I disable java, I don't care whether it is or gets blocklisted, I don't want
> to see any UI for it or anything, I would think.
> 
Yeah, that makes more sense. I'll move it back.

Comment 10

[Michael Wu [:mwu]]

Attachment: Add plugins blocklisting support, v3

Check for disabled java before blocklisted plugin, fix stupid mistake in UpdatePluginInfo.

Comment 11

[Michael Wu [:mwu]]

Checking in content/base/src/nsObjectLoadingContent.cpp;
/cvsroot/mozilla/content/base/src/nsObjectLoadingContent.cpp,v  <--  nsObjectLoadingContent.cpp
new revision: 1.46; previous revision: 1.45
done
Checking in content/base/src/nsObjectLoadingContent.h;
/cvsroot/mozilla/content/base/src/nsObjectLoadingContent.h,v  <--  nsObjectLoadingContent.h
new revision: 1.17; previous revision: 1.16
done
Checking in modules/plugin/base/public/nsIPluginTag.idl;
/cvsroot/mozilla/modules/plugin/base/public/nsIPluginTag.idl,v  <--  nsIPluginTag.idl
new revision: 1.4; previous revision: 1.3
done
Checking in modules/plugin/base/public/nsPluginError.h;
/cvsroot/mozilla/modules/plugin/base/public/nsPluginError.h,v  <--  nsPluginError.h
new revision: 1.4; previous revision: 1.3
done
Checking in modules/plugin/base/src/nsPluginHostImpl.cpp;
/cvsroot/mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp,v  <--  nsPluginHostImpl.cpp
new revision: 1.582; previous revision: 1.581
done
Checking in modules/plugin/base/src/nsPluginHostImpl.h;
/cvsroot/mozilla/modules/plugin/base/src/nsPluginHostImpl.h,v  <--  nsPluginHostImpl.h
new revision: 1.107; previous revision: 1.106
done

Comment 12

[Robert Strong (they/them - no direct email)]

Filed bug 391633 for AMO to add support to the blocklist for plugins... not sure if you want this bug to block or depend on that bug.

Comment 13

[Tony Chung [:tchung]]

Verified fix in bug 421993.  

Litmus test case: https://litmus.mozilla.org/show_test.cgi?id=5201