330615 - Convert Thunderbird to use the winstripe theme in mozilla\toolkit

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

**Note: this does not mean the thunderbird theme is getting redesigned in winstripe**

Currently mozilla\toolkit has two themes for windows and linux: winstripe and qute. Qute is built by Thunderbird. Firefox and xul runner use winstripe.

I think we can get closer to having thunderbird built on top of xul runner if Thunderbird was converted to use the winstripe theme for toolkit instead of qute. 

And it will make theme maintence a lot easier since I won't have to keep porting winstripe changes back to qute.

There shouldn't be much of a noticeable UI difference with this, just a handful of toolkit artwork I think. At least that's the hope :)

Comment 1

[Scott MacGregor]

Attachment: the fix

There might be more style merging to be done later, but in general, things looked pretty much the same.

There was one issue with the compose window's menulist drop down marker getting drawn incorrectly because the image in winstripe isn't tall enough, but that was easily worked around.

The install button in the EM and TM for Thunderbid lost it's image, but that work is getting overhauled by rob strong anyway and we can always add the qute image back if we need to after Rob's done.

Eventually I'll start CVS removing qute from toolkit, but want to keep it around for a little while in case I have to do more style merging into winstripe.

Comment 2

[Scott MacGregor]

this patch is now in the branch and trunk. But I'm going to leave this bug open until I actually cvs remove the qute files from the repository.

Comment 3

[Scott MacGregor]

Attachment: [fix checked in branch adn trunk]override moz-margin-end for several toolbarbutton-icons

winstripe has a style rule for toolbarbutton-icon which sets a 5 pixel moz-margin end which we didn't have in qute.

This is causing several of our close buttons to be offset by 5 pixels. I'm overriding the moz-margin-end for these specific buttons.

Comment 4

[Scott MacGregor]

Attachment: fix some throbber regressions

Remove some obsolete CSS files, and fix some issues with the throbber icon now that we are using winstripe.

Comment 5

[Scott MacGregor]

Attachment: fix missing offline/online indicator

Comment 6

[Scott MacGregor]

FYI, I've now CVS removed the qute theme from the trunk for mozilla\toolkit.

Comment 7

[Philip Puryear]

(In reply to comment #6)
> FYI, I've now CVS removed the qute theme from the trunk for mozilla\toolkit.
> 

I think you forgot to remove the makefiles for that directory from allmakefiles.sh. Also, mozilla/toolkit/themes/qute/Makefile.in was not removed.