Closed Bug 330674 Opened 18 years ago Closed 17 years ago

Add ability to show/hide Lightning sidebar/pane quickly

Categories

(Calendar :: Lightning Only, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

VERIFIED INVALID

People

(Reporter: ssitter, Assigned: mattwillis)

Details

Attachments

(1 obsolete file)

Add ability to show/hide Lightning sidebar/pane

I have a lot of mail folders and accounts shown in Thunderbird sidebar. I want to be able to show/hide the Lightning sidebar quickly without having to drag the sidebar to bottom/from bottom every time.

The solution could be
- a custom toolbar button and/or
- a command in 'View' or 'Calendar' menu and/or
- a keyboards shortcut
Whoever will start working on this should at least read this topic @ Mozillazine: http://forums.mozillazine.org/viewtopic.php?t=393382
It proposes a toolbar button that shows/hides Lightning and also supplies some initial code for this.
Wouldn't be simpler/cleaner/take-less-space to give the sidebar pane splitter a clickable grippy?  Then you can just click on it rather than having to drag the splitter.

Recent Thunderbird nightlines move the search bar into the toolbar, so the toolbar has very little space for additional buttons.  People have complained that the sidebar is too crowded so I don't think we want to add a row of buttons there if it can be avoided.
imo, an optional grippy is a good idea, i have grippies on two other splitters in Tb so it looks missing here.  furthermore, an extension has just been developed to provide a toolbar toggle button, which also toggles all lightning toolbar buttons of as well if lightning is off.

http://forums.mozillazine.org/viewtopic.php?t=412528
Attached patch adds grippy to sidebar splitter (obsolete) — — Splinter Review
This patch simply adds a grippy to the splitter atop the sidebar.
Assignee: nobody → mattwillis
Status: NEW → ASSIGNED
Attachment #237633 - Flags: second-review?(dmose)
Attachment #237633 - Flags: first-review?(mvl)
Comment on attachment 237633 [details] [diff] [review]
adds grippy to sidebar splitter

over to ssitter per mvl's irc comment
Attachment #237633 - Flags: first-review?(mvl) → first-review?(ssitter)
(In reply to comment #5)
> (From update of attachment 237633 [details] [diff] [review] [edit])
> over to ssitter per mvl's irc comment
> 

the grippy is necessary, for visual consistency.  but it leaves space.  perpelexed by the apparent lack of adding a 1)menu item 2)toolbar button, to collapse the calendar.  clearly a toolbar button is...optional.
Comment on attachment 237633 [details] [diff] [review]
adds grippy to sidebar splitter

r1=ssitter
This might help us for Lightning mac version. But on win32 this doesn't improve situation because the grippy is neither visible nor clickable. [http://lxr.mozilla.org/mozilla/source/toolkit/themes/winstripe/global/splitter.css#69]
Attachment #237633 - Flags: first-review?(ssitter) → first-review+
maybe this will help: i fixed this for Lightning by downloading the grippies ext at https://addons.mozilla.org/firefox/2242/ and adding the below to grippies.xul in the grippies.jar file:

  <splitter id="folderpaneCalendarSplitter"
            orient="vertical"
            collapse="after"
            style="">
    <grippy onclick="ChangeMessagePaneVisibility(!IsMessagePaneCollapsed());"/>
  </splitter>

Comment on attachment 237633 [details] [diff] [review]
adds grippy to sidebar splitter

removing review request per comments in bug
Attachment #237633 - Attachment is obsolete: true
Attachment #237633 - Flags: second-review?(dmose)
This bug is invalid with checkin of patch from bug 371916. -> Nominating for marking INVALID.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → INVALID
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: