Closed Bug 371916 Opened 13 years ago Closed 13 years ago

switch between mail and calendar view

Categories

(Calendar :: Lightning Only, enhancement)

enhancement
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: michael.buettner, Assigned: michael.buettner)

References

Details

(Whiteboard: [roadmap 0.7])

Attachments

(5 files, 5 obsolete files)

this issue belongs to the topic of improving the calendar views, please refer to [1] for further details. in this bug i would like to address the specific issue of switching between the mail- and calendar-view in thunderbird/lightning. there has already been some discussion related to this feature, please refer to [2] and [3] for further details.

[1] http://wiki.mozilla.org/Calendar:Improving_the_Calendar_Views
[2] http://groups.google.org/group/mozilla.dev.apps.calendar/browse_thread/thread/45b31925ef0f6aa6/41f21befb5a042ef#41f21befb5a042ef
[3] http://groups.google.org/group/mozilla.dev.apps.calendar/browse_thread/thread/9663d69c1e4a303a/ecd55ea3b98c651e#ecd55ea3b98c651e
Attached file binary-files v1 (obsolete) —
initial version of the icons and related images. this is only a draft and will be replaced, i just want to get this out of my tree.
Attached patch patch v1 (obsolete) — Splinter Review
initial version of the patch. this is only a draft version and i will at least submit one more iteration until this it is ready for review, i just want to get this out of my tree.
Blocks: 327783
Blocks: 379622
Attached file binary-files v2
These are the final icons for the mode switch toolbar. There's currently only one version (winstripe) but I put the file under pinstripe & winstripe in order to easily allow a pinstripe version without the need to modify the jar.mn.
Attachment #256609 - Attachment is obsolete: true
Attached patch patch v2 (obsolete) — Splinter Review
Again just a work-in-progress version of this patch. Technically it is now a toolbar instead of some howe-grown clickable image, including full support for customization. The customize toolbar dialog also has a new (on-the-fly) option that allows to place the mode toolbar at the bottom or top of the left side pane. There's still a minor flaw that prevents this patch from being final. Placing the mode toolbar at the top of the left pane and reseting the content in the customize  dialog doesn't work.
Attachment #256610 - Attachment is obsolete: true
nice job :-)

i know this is a minor version. but still one little comment.

a) i pressed the calendar-button after start of thunderbird. -> all pannels change their views. 
b) then i pressed mail-button -> only the left panel changes his view (in classic view). the right panel show the calendar view.
c) then i selected an inbox one time. after this all panels change their views, if i toggle between mail and calendar.

is this okay?

regards 
steff
(In reply to comment #5)
thanks for this early comment, it's great to have the possibility to get rid of bug before this patch lands.

> b) then i pressed mail-button -> only the left panel changes his view (in
> classic view). the right panel show the calendar view.
hm, no, the described behavior is indeed not intended. clicking on the mail button should bring back the mail tree as well as the standard list of mails plus the mail preview, the classic 3pane view of thunderbird. is there anything written in the error console? do you have any other extension installed that could probably conflict with the way this patch modifies the dom tree? thanks again for testing this patch, thumbs up... :-)
okay ... i found something. 

when you set the "all folders"-view everything is okay. but when you set the "favorite folders"-view the error described behavior is active.

in the error console is nothing.

but in the "favorite folders"-view the "start page" is missing after start of thunderbird. maybe, i think this is a bug of thunderbird. sorry.... 

(In reply to comment #7)
> when you set the "all folders"-view everything is okay. but when you set the
> "favorite folders"-view the error described behavior is active.
I can easily reproduce this behavior. Thanks for pointing this out, I'll fix that for the next iteration of this patch. Cool, this saved me the trouble that I would have had if this patch had landed as is...

> but in the "favorite folders"-view the "start page" is missing after start of
> thunderbird. maybe, i think this is a bug of thunderbird. sorry.... 
Hm, I can't reproduce this. The "start page" comes up as expected, regardless of which option I use in the tree pane. Which version of Thunderbird do you use? Has this behavior anything to do with this particular patch or Lightning? If not, it sounds like an unfortunate bug in thunderbird.
(In reply to comment #8)
> Which version of Thunderbird do you use? Has this behavior anything to do with this particular patch or Lightning?

i checked out from cvs yesterday midday.
3.0a1 (20070507) and lightning 0.6a1. but this bug is also in my stable build thunderbird 2.0.0.0 and lightning 0.5pre (20070507) (with and without lightning)
so i think this is a bug of thunderbird. :-)

and still finally a little question :-)
i miss a pref that saves the last state at closing thunderbird. everytime when i start thunderbird, both buttons (mail, calendar) are not pressed. and when i close with calendar-view, thunderbird starts next time with mail-view. is this intended?




(In reply to comment #9)
> so i think this is a bug of thunderbird. :-)
pfuhh, ok, one thing less to care about...

> i miss a pref that saves the last state at closing thunderbird. everytime when
> i start thunderbird, both buttons (mail, calendar) are not pressed. and when i
> close with calendar-view, thunderbird starts next time with mail-view. is this
> intended?
It's a bug that the mail-button is initially not pressed, there's just a xul-attribute missing. It is indeed intended that thunderbird always comes up with the mail-view, even if the calendar (or the upcoming task view) was visible when it was closed.
Attached patch patch v3 (obsolete) — Splinter Review
This is the latest and greatest version of the patch. The following additions and enhancements have been made:

- I solved the problem that the customize dialog was confused by dynamically changing the position of the toolbox in the dom tree. What caused all the trouble is the fact that the constructor of the toolbar binding gets executed twice if the dom node is inserted at a different location in the tree. The controlling code now takes this into account.

- The mode toolbar integrates nicely with the toolbar customize dialog. The user  can configure if the toolbar should be on top or bottom of the tree pane. This option is only offered if we're customizing the mode toolbar and modification get rejected if the customize dialog is canceled.

- Switching between mail and calendar now works also in case the user has modified the mail tree pane to display a different view (recent mails, etc).

I'm holding this off, since 0.5 is still on its way. Probably a good idea is to add the different toolbar contents depending on the currently active mode to this patch before it lands. But this depends on when 0.5 is finally out of the door.
Attachment #263996 - Attachment is obsolete: true
The last piece that was missing from the patch was the enhancement that buys us the mode dependent toolbars. For further information see the first link from my comment #1.

Basically, depending on the mode we're in (mail,calendar,task) we want to have different buttons displayed in the main application toolbar. This also brings the difficulty that each of them can be customized. It would be great if all of this could be achieved without ever leaving the customize toolbar dialog. Please see the attached screenshot for how the enhanced dialog should look like.

Also note the new option 'location' at the lower left of the dialog. This option is only available if we're customizing the 'mode' toolbar which can be displayed at the top or bottom of the folder pane.
Attached patch patch v4 (obsolete) — Splinter Review
This rather giant patch finally brings all those features into life. I probably already explained all the high level details in my comments above. It's finally ready for review.

I had to play some tricks on the toolbar in order to be able to dock it at the top or bottom of the folder pane. The necessary code can be found at ltnOnLoad(), in the local functions retrieveToolbarProperties() and restoreToolbarProperties(). All of this is necessary since the constructor of the toolbar binding gets executed each time it is dynamically re-routed in the dom tree which caused some trouble.

Something else that strikes me as being worth to be mentioned is the fact that I moved quite some code from messenger-overlay-sidebar.xul to messenger-overlay-toolbar.xul. All the toolbar related stuff can now be found in  messenger-overlay-toolbar.xul. Everything that's related to inject the rest of Lightning can be found in messenger-overlay-sidebar.xul. That's why I also changed messenger-overlay-toolbar.xul to overlay mailWindowOverlay.xul.

The new file messenger-overlay-toolbar.js handles all the toolbar related stuff, such as switching the application mode, bringing the customize toolbar dialog up, tear it down, handle all enable/restore stuff, etc.

I also had to override quite some bits and pieces from the original customize toolbar dialog. All this stuff can be found in the new files customize-toolbar.xul (overlays the original dialog) and customize-toolbar.js.

That's all what I currently can think of as a starting point for reviewing this patch...
Attachment #264236 - Attachment is obsolete: true
Attachment #265951 - Flags: ui-review?(christian.jansen)
Attachment #265951 - Flags: review?(daniel.boelzle)
Berend, it would be great if you could find some time to have a look on this patch and write some comments here. Please feel free to do a secondary pre- or post-review ;-)
Duplicate of this bug: 382062
A few fly-by comments:

1. Both customizeToolbar files (xul + js) probably copied a lot from the 
   original files (Toolkit or Sunbird or Firefox etc.). That should be 
   reflected in the licensing header. So take the "Original author" 
   sentence from the original file and add yourself as a contributor (which you 
   already did)

2. At the end of the patch to messenger-overlay-toolbar.xul there is a 
   "\ No newline at end of file". Please add the additional line.

3. General observation:
   I see this bug as a great possibility to finally get rid of the internal 
   UI fork between Sunbird (using calendar.xul) and Lightning (using the 
   various overlay-files).

   What I would like to see in the end is Lightning using an enhanced 
   calendar.xul (calendar.xul + the lightning goodies like the agenda). In this 
   ideal world the overlay would be reduced to provide just the switching 
   mechanism between the different modes and other mail-related functionality.

   That would not only reduce code duplication but would also ease our testing 
   efforts and would make developing for both Lightning and Sunbird a lot 
   easier.

   Perhaps this is too much work to do it all in this bug. But IMO a follow-up 
   bug should definitely be filed for this.

Comments?
Ok, I applied the patch and found the following:

1. Right at the end of the build process I get an error:

  adding: locale/en-US/calendar/preferences/timezones.dtd (stored 0%)
  adding: locale/en-US/calendar/preferences/views.dtd (stored 0%)
  adding: locale/en-US/calendar/sun-calendar-event-dialog.dtd (stored 0%)
  adding: locale/en-US/calendar/sun-calendar-event-dialog.properties (stored 0%)
  adding: locale/en-US/calendar/calendar-invitations-dialog.dtd (stored 0%)
Stripping lightning package directory...
../../dist/xpi-stage/lightning
make[5]: *** [libs] Error 2
make[5]: Leaving directory `/cygdrive/c/mozilla1.8/Lt/calendar/lightning'
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/cygdrive/c/mozilla1.8/Lt/extensions/lightning'
make[3]: *** [libs] Error 2
make[3]: Leaving directory `/cygdrive/c/mozilla1.8/Lt/extensions'
make[2]: *** [tier_99] Error 2
make[2]: Leaving directory `/cygdrive/c/mozilla1.8/Lt'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/cygdrive/c/mozilla1.8/Lt'
make: *** [build] Error 2

I don't know, if it's my config, although this was a vanilla 1.8 branch clobber build. Interestingly all the necessary bits are in dist/xpi-stage and I could create a lightning.xpi file and install it in Thunderbird.

2. We should offer all the icons, that Sunbird supplies in its Customize 
   toolbar dialog also in the Lightning calendar mode.

3. If you customize your toolbar in mail mode and switch to calendar mode in 
   the customize toolbar and click 'OK' (no need to change anything), the 
   switch buttons in the lower left corner aren't working anymore. The same 
   goes for the other way around (calendar mode -> mail mode).

   If you switch to customizing the mode toolbar, this does not happen and you 
   can "heal" the inactiveness of the buttons by customizing the mode toolbar.

4. I don't fully understand, what the mode toolbar is used for? What's the 
   use-case?

5. I also don't understand, why we need the ability to customize the calendar 
   mode toolbar while in mail mode. What is the use-case here?

I hope that helps, Mickey?
One more thing:

6. At least in mail mode, there is no clear separation between the switching 
   panel and the folder list. That looks ugly IMO.
(In reply to comment #16)
> 1. Both customizeToolbar files (xul + js) probably copied a lot from the 
>    original files (Toolkit or Sunbird or Firefox etc.).
You're absolutely right, I'll change that.

> 2. At the end of the patch to messenger-overlay-toolbar.xul there is a 
>    "\ No newline at end of file". Please add the additional line.
Eagle eyes ;-) Yes, I'll address that.

> 3. General observation:
>    I see this bug as a great possibility to finally get rid of the internal 
>    UI fork between Sunbird (using calendar.xul) and Lightning (using the 
>    various overlay-files).
> 
>    ...
>
>    Perhaps this is too much work to do it all in this bug. But IMO a follow-up 
>    bug should definitely be filed for this.
This patch is definitely not the appropriate place to address this issue. But it should be addressed, that's for sure. Probably we need several patches where each of them provides one step towards that goal. I think the follow-up bug should be filed and serve as a meta-bug where all others depend on that one. You could do me a favor and just file it, if you don't mind. Feel free to assign it directly to me, that's fine.
(In reply to comment #17)
> 1. Right at the end of the build process I get an error:
Hm, that looks strange to me. Are you sure this doesn't also happen without the patch? I never saw something like that and Steffen Röttig also already tried it out, at least he didn't mention anything similar...

> 2. We should offer all the icons, that Sunbird supplies in its Customize 
>    toolbar dialog also in the Lightning calendar mode.
If I understand correctly, you mean that we should not only show the calendar specific items on the (new) calendar toolbar, but also (additionally) on the main thunderbird toolbar? If that's what you're suggesting, I'll leave this question to Christian.

> 3. If you customize your toolbar in mail mode and switch to calendar mode in 
>    the customize toolbar and click 'OK' (no need to change anything), the 
>    switch buttons in the lower left corner aren't working anymore. The same 
>    goes for the other way around (calendar mode -> mail mode).
Ups, thanks for pointing that out. This cries out for another iteration of the patch...

> 4. I don't fully understand, what the mode toolbar is used for? What's the 
>    use-case?
Huh? That's what this patch is all about - introducing different modes to clearly separate the interfaces from each other. Christian, that's your part of the story.

> 5. I also don't understand, why we need the ability to customize the calendar 
>    mode toolbar while in mail mode. What is the use-case here?
The customize toolbar dialog is now capable of customizing *all* available toolbars. The use case is that the user otherwise would need to first switch to some other mode in order to customize the toolbar of that other mode. That might not be obvious. On the other hand, it's a nice shortcut that doesn't helps reduce complexity and doesn't hurt.

> 6. At least in mail mode, there is no clear separation between the switching 
>    panel and the folder list. That looks ugly IMO.
Ups, that's true, I'll change that...

Before addressing the above bits and pieces, I'm still waiting for anything that Christian might add to the equation and for Daniels review.
(In reply to comment #20)
>> 2. We should offer all the icons, that Sunbird supplies in its Customize 
>>    toolbar dialog also in the Lightning calendar mode.
>
> If I understand correctly, you mean that we should not only show the calendar
> specific items on the (new) calendar toolbar, but also (additionally) on the
> main thunderbird toolbar?

No. Currently only the following Calendar-specific icons are available in the Calendar toolbar: New Event, New Task, Day View, Week View, Month View, Go to Today

In addition to these icons Sunbird also makes the following icons available:
Edit, Delete, Cut, Copy, Paste, Import, Export, Subscribe, Publish, Print, Choose Date, Reload

IMO all of these these should also be available in Calendar mode. The same goes for the Multiweek view icon, if it is someday decided, that Lightning should also have that.
 
>> 4. I don't fully understand, what the mode toolbar is used for? What's the 
>>    use-case?
>
> Huh? That's what this patch is all about - introducing different modes to
> clearly separate the interfaces from each other.

You misunderstood me. With the current iteration of the patch you can customize three toolbars: Mail Toolbar, Calendar Toolbar and Mode Toolbar.

I was wondering what the latter was for. I see no use case for a Mode Toolbar.
 
>> 5. I also don't understand, why we need the ability to customize the 
>>    calendar mode toolbar while in mail mode. What is the use-case here?
>
> The customize toolbar dialog is now capable of customizing *all* available
> toolbars. The use case is that the user otherwise would need to first switch 
> to some other mode in order to customize the toolbar of that other mode. 
> That might not be obvious. On the other hand, it's a nice shortcut that 
> doesn't helps reduce complexity and doesn't hurt.

Personally I see this as a nice-to-have feature, but I'm worried about the additional complexity. This made the bug (Issue 2 on my list) in your implementation possible. Without this such a bug would never have existed.
On my review I found the following codepieces unattractive:

mozilla/calendar/lightning/content/messenger-overlay-toolbar.js:
>+    EnableDisableHierarchy(document.getElementById('mail-menubar'),false);
>+    EnableDisableHierarchy(document.getElementById('mail-bar2'),false);
>+    EnableDisableHierarchy(document.getElementById('calendar-toolbar'),false);
>+  } else {
>+    EnableDisableHierarchy(document.getElementById('mode-toolbar'),false);
>+  }
>+
I found this logic to toggle the child elements three times. I guess you could extract it to one single function.


Similarily the functions ltnSwitch2Mail() and ltnSwitch2Calendar() offer the same functionality applied to the same DOM-objects only with different signs:
ltnSwitch2Mail():
>+    var switch2mail = document.getElementById("switch2mail");
>+    var switch2calendar = document.getElementById("switch2calendar");
>+    switch2mail.setAttribute("checked","true");
>+    switch2calendar.removeAttribute("checked");
>+
>+    var mailToolbar = document.getElementById("mail-bar2");

ltnSwitch2Calendar():
>+    var switch2mail = document.getElementById("switch2mail");
>+    var switch2calendar = document.getElementById("switch2calendar");
>+    switch2calendar.setAttribute("checked","true");
>+    switch2mail.removeAttribute("checked");

I guess when the 'task' toolbarbutton will added this functionality will even be copied and extended another time so I think this should be moved to one function in time.
(In reply to comment #20)
> (In reply to comment #17)
>> 1. Right at the end of the build process I get an error:
> Hm, that looks strange to me. Are you sure this doesn't also happen without the
> patch? I never saw something like that and Steffen Röttig also already tried
> it out, at least he didn't mention anything similar...
> 
>> 2. We should offer all the icons, that Sunbird supplies in its Customize 
>>    toolbar dialog also in the Lightning calendar mode.
> If I understand correctly, you mean that we should not only show the calendar
> specific items on the (new) calendar toolbar, but also (additionally) on the
> main thunderbird toolbar? If that's what you're suggesting, I'll leave this
> question to Christian.

I'm no sure if we really want that. In the end we'll have 4 toolbars -- one for mail, one for calendaring, one for tasks plus the mode switch. Due to that the customize dialog would be filled with about 35 - 45 icons. That's from my point of view to much.
> 
>> 3. If you customize your toolbar in mail mode and switch to calendar mode in 
>>    the customize toolbar and click 'OK' (no need to change anything), the 
>>    switch buttons in the lower left corner aren't working anymore. The same 
>>    goes for the other way around (calendar mode -> mail mode).
> Ups, thanks for pointing that out. This cries out for another iteration of the
> patch...
> 
>> 4. I don't fully understand, what the mode toolbar is used for? What's the 
>>    use-case?
> Huh? That's what this patch is all about - introducing different modes to
> clearly separate the interfaces from each other. Christian, that's your part of
> the story.

We might have a naming issue here. Maybe the term "Mode Toolbar" is too ambiguous. 
> 
>> 5. I also don't understand, why we need the ability to customize the calendar 
>>    mode toolbar while in mail mode. What is the use-case here?
> The customize toolbar dialog is now capable of customizing *all* available
> toolbars. The use case is that the user otherwise would need to first switch to
> some other mode in order to customize the toolbar of that other mode. That
> might not be obvious. On the other hand, it's a nice shortcut that doesn't
> helps reduce complexity and doesn't hurt.
> 
>> 6. At least in mail mode, there is no clear separation between the switching 
>>    panel and the folder list. That looks ugly IMO.
> Ups, that's true, I'll change that...
> 
> Before addressing the above bits and pieces, I'm still waiting for anything
> that Christian might add to the equation and for Daniels review.
> 
> 
Comment on attachment 265951 [details] [diff] [review]
patch v4

Code looks ok, r=dbo with Simon's comments resolved; upper-case function names should be changed to lower-case.
Attachment #265951 - Flags: review?(daniel.boelzle) → review+
This should go into 0.7
Flags: blocking-calendar0.7+
Target Milestone: --- → 0.7
Whiteboard: [roadmap 0.7]
(In reply to comment #21)
>> If I understand correctly, you mean that we should not only show the 
>> calendar specific items on the (new) calendar toolbar, but also 
>> (additionally) on the main thunderbird toolbar?
> 
> No. Currently only the following Calendar-specific icons are available in the
> Calendar toolbar: New Event, New Task, Day View, Week View, Month View, Go to
> Today
> 
> In addition to these icons Sunbird also makes the following icons available:
> Edit, Delete, Cut, Copy, Paste, Import, Export, Subscribe, Publish, Print,
> Choose Date, Reload
> 
> IMO all of these these should also be available in Calendar mode. The same 
> goes for the Multiweek view icon, if it is someday decided, that Lightning 
> should also have that.

Mickey, any update on this? I haven't seen a reply to that.

>> Huh? That's what this patch is all about - introducing different modes to
>> clearly separate the interfaces from each other.
> 
> You misunderstood me. With the current iteration of the patch you can 
> customize three toolbars: Mail Toolbar, Calendar Toolbar and Mode Toolbar.
> 
> I was wondering what the latter was for. I see no use case for a Mode Toolbar.

I think I finally found out what the Mode Toolbar is there for and I also immediately found a bug there :-) 

With the patch the toolbal shows up with large icons and text, but if you customize it for the first time, icon-mode is selected by default but icontext-mode is still shown. The toolbar will only switch to icon-mode, if you switch to another mode (e.g. text-mode) first and then switch back to icon-mode.

It would be gre4at if you could fix that before checkin.

>> The customize toolbar dialog is now capable of customizing *all* available
>> toolbars. The use case is that the user otherwise would need to first switch 
>> to some other mode in order to customize the toolbar of that other mode. 
>> That might not be obvious. On the other hand, it's a nice shortcut that 
>> doesn't helps reduce complexity and doesn't hurt.
> 
>Personally I see this as a nice-to-have feature, but I'm worried about the
>additional complexity. This made the bug (Issue 2 on my list) in your
>implementation possible. Without this such a bug would never have existed.

Mickey, any update on this? I haven't seen a reply to that. Do you want to keep that feature?
Status: NEW → ASSIGNED
Duplicate of this bug: 327783
Overall I'm pretty impressed from this feature it works really great. Good work :-)

Below you find a short list of issues which I found during my evaluation.

Customize Toolbar Dialog

  "Toolbar" Drop Down
  *  Switching from one TB to another causes the dialog to jump
  *  Switching from one TB to another is not possible if Customize
     toolbar is called from the menu.
  
  Calendar Toolbar
  * Container should offer all Sunbird icons but not:
    Cut, Copy, Paste
  * We should use Thunderbirds standard Print & Delete icon
  * All other icons need to be redesigned for being
    Thunderbird more compliant
  * Icon sizes should align with Mail Mode icons.

Mode Toolbar

  * 0px Space between item & border -> should be at least 5px
  * 1px border missing at the top
  * Tootips are missing
  * Ovelay/Badge for displaying number new
    Mails/Invitations/Tasks is missing
  * Any ideas for a better name of the toolbar? Mode toolbar
    sounds very technical to my ears.

I'll attach a mock-up which shows some of the fine tuning.
(In reply to comment #28)
> Calendar Toolbar
> * Container should offer all Sunbird icons but not:
>   Cut, Copy, Paste

Yes, I also raised this issue.

> * All other icons need to be redesigned for being Thunderbird more compliant

Yes, but way beyond the scope of this bug. This should go into a spin-off.

> * Icon sizes should align with Mail Mode icons.

That should be covered by the same spin-off bug as above.
does this patch fix this problem (which keeps getting duped as in #27)?  if it doesn't belong here or will be fixed here, i will open another bug.

lightning must accommodate all Tb views, even those
(mail.pane_config.dynamic=3) where the message list and message pane do not
form a 'box'.  lightning needs to occupy one or the other in this case. 
currently, lighting permanently breaks Tb with that view.
Yes, this fixes this issue for all TB layouts.
Christian, are you willing to set this ui-review+ or is there still anything else missing from this patch? My plan was to collect any comments in order to incorporate all of them in a final iteration of this patch. If you're firing off a positive review, I'll provide a new patch ASAP.
(In reply to comment #33)
> Christian, are you willing to set this ui-review+ or is there still anything
> else missing from this patch? 

I think it is ok. I'll set the ui-review to +.

My plan was to collect any comments in order to
> incorporate all of them in a final iteration of this patch. If you're firing
> off a positive review, I'll provide a new patch ASAP.

I'll count on you ;-) I'll sent you the ovelay images for the badges as soon as possible. 

Attachment #265951 - Flags: ui-review?(christian.jansen) → ui-review+
Attached patch patch v5Splinter Review
This final version of the patch addresses the following issues that have been raised since the previous iteration:

- added all other commands from sunbird (see comment #17 and comment #21)
- fixed issue regarding disabled state of the mode toolbar (see comment #17)
- license headers fixed in customizeToolbar.js/xul (see comment #16)
- missing newline in messenger-overlay-toolbar.xul (see comment #16)
- the customize dialog keeps it location once it's open (see comment #28)
- the customize dialog now works even if was opened from the menu (see comment #28)
- added some css rules to address fine tuning (see comment #28)

I carried over the r+ flags. I really don't want to add anything else to this patch, please let it land as it currently stands and take care of further issues in follow-up bugs. This patch is already larger than it should be.
Attachment #265951 - Attachment is obsolete: true
Attachment #270324 - Flags: ui-review+
Attachment #270324 - Flags: review+
Whiteboard: [roadmap 0.7] → [roadmap 0.7][checkin needed after 0.5]
patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [roadmap 0.7][checkin needed after 0.5] → [roadmap 0.7]
verified with lightning 0.7pre 2007063017
Status: RESOLVED → VERIFIED
Just checked with tb 2.0.0.4 and found one small issue. ( I really like this new feature by the way!!!!)

If you still have the icons of lightning in your thunderbird tool bar and do the following:

open TB click email, click on the go to today icon on the TB toolbar (the calendar   appears, REALLY fast by the way compared to previously!) Now the view is the left  side bar contains the e-mails and the main view contains the calendar. (which might be a little confusing)

Then if you click the already selected inbox, the view does not switch back to email. you have to first click a different inbox to select the mail view again (of course now not using the new buttons in the bottom...)

(In reply to comment #38)
> Just checked with tb 2.0.0.4 and found one small issue. ( I really like this
> new feature by the way!!!!)
> 
> If you still have the icons of lightning in your thunderbird tool bar and do
> the following:
> 
> open TB click email, click on the go to today icon on the TB toolbar (the
> calendar   appears, REALLY fast by the way compared to previously!) Now the
> view is the left  side bar contains the e-mails and the main view contains the
> calendar. (which might be a little confusing)
> 
Bug 386479
Duplicate of this bug: 330057
In TB 1.5.0.10 Portable Edition I get the following error on clicking the calendar-view button:

Fehler: mailToolbar has no properties
Quelldatei: chrome://lightning/content/messenger-overlay-toolbar.js
Zeile: 140

My OS: Windows XP SP2

Should we reopen this bug or make a new one for that?
(In reply to comment #41)
Please file a new one.
I just installed lightning v0.7 and I do like the new way to switch between the email and calender view. Alas I think the layout of Thunderbird doesn't need another component (I mean the Mode-toolbar). 

Why isn't it therefor possible to have the calender-view-icon in the email-toolbar (like it is shown in the attached picture)? Currently I cannot seem to be able to put the calender-icon there. Is that possible at all with the current codebase?

Of course being able to just have the emailview-icon in the calender view is implied by this.
You need to log in before you can comment on or make changes to this bug.