330878 - Firefox leaks the update.xml document when it checks for updates

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I use the leak tools documented in http://dbaron.org/log/2006-01#e20060110a and http://dbaron.org/log/2006-01#e20060114a pretty much all the time I run Firefox, and every day or so (roughly; it certainly matches my expectation of how often Firefox checks for updates) the log contains something like this:

Leaked outer window a00bd70 at address a00bd70.
Leaked inner window a0932f8 (outer a00bd70) at address a0932f8.
 ... with URI "about:blank".
Leaked document at address afa4f90.
 ... with URI "https://aus2.mozilla.org/update/1/Firefox/1.6a1/0000000000/Linux_x86-gcc3/en-US/default/update.xml".
Summary:
Leaked 2 out of 386 DOM Windows
Leaked 1 out of 359 documents
Leaked 0 out of 98 docshells

(This example shows no other leaks.)

So we seem to leak stuff when we check for updates.

Comment 1

[dolphinling]

Dupe of bug 323402? That has a local url and leaks 2 DOM Windows and 0 documents, this is remote and leaks 2 DOM Windows and 1 document, though, so not sure.

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

No, it's not a duplicate.  That's about leaking updates.xul (part of the UI) when using the UI; this is about leaking the update.xml fetched from the server and has no UI interaction.

Comment 3

[Jonathan Baron]

I don't know if this is the same bug, but with the new leak
detector (http://dbaron.org/mozilla/leak-monitor/), I get a leak
every time I try Help/Check_for_updates.  The detector says
it is in:
chrome://mozapps/content/updates/updates.js
lines 505-508, 514-526, 532-537, 543-547
(I cannot find this file.)

Comment 4

[Ryan VanderMeulen [:RyanVM]]

I'm pretty sure that's bug 336955 you're experiencing :)

Comment 5

[Michael Wu [:mwu]]

Attachment: FIx memory leak in nsUpdateService

Releases our XMLHttpRequest object when we're done with it.

Comment 6

[Darin Fisher]

Comment on attachment 225497 [details] [diff] [review]
FIx memory leak in nsUpdateService

Looks good, r+a=darin

Comment 7

[Jeff Walden [:Waldo]]

Fix checked in on branch and trunk.