33091 - Setting opacity causes a crash when using nsViewManager2

Status: VERIFIED WORKSFORME

(Core Graveyard :: GFX, defect, P3)

Description

[Kevin McCluskey (gone)]

The blender seems to be writing outside the bounds of the memory allocated for 
the offscreen buffers, causing a crash.

Comment 1

[Kevin McCluskey (gone)]

Attachment: static version of test13.html which causes a crash

Comment 2

[Patrick C. Beard]

Attachment: Patches that fix these problems by doing range checking in blender

Comment 3

[Chris Hill]

I think the range checking fixed the crashes.  However, while the range checking 
is keeping things in bounds, it isn't producing the correct coordinates.

There are two independent calls to rangeCheck, one for the source and one for 
the destination.  The range checking is not independent however.  If the 
destination origin is changed because it is less than 0, there must be a 
corresponding change to the source origin (incrementing it by the same amount 
that the destination origin was), or the wrong part of the image will be 
blended.

If the origins are greater than the extents of the surfaces, shouldn't the blend 
function just abort?

Comment 4

[Patrick C. Beard]

Fixed in mozilla/gfx/src/nsBlender.cpp v3.16 by adding range checking code.

Comment 5

[leger]

Adding crash keyword

Comment 6

[Chris Petersen]

With the May 25th build on Mac and Windows, the static sample file is rendered 
properly. However, the May 25 Linux build renders the page partially and then 
crashes. Reopening bug for this reason.

Comment 7

[Andreas Franke (gone)]

The current crash on Linux has been reported as bug 38909. Same stack trace.

Comment 8

[Andreas Franke (gone)]

Actually, bug 38909 is a verified duplicate of bug 17356.

Comment 9

[Patrick C. Beard]

Reassigning to rightful owner of bug.

Comment 10

[Kevin McCluskey (gone)]

Attachment: Test13 with opacity put back in

Comment 11

[Kevin McCluskey (gone)]

Not crashing on WINNT with latest build.
Waqar could you test this on Linux? (Use my attachment test13.html with 
transparency put back in)

Comment 12

[waqar]

It does not carsh with 2000/08/03 build. I used Test13 and the attachement 
(12331) that Kevin had attached to this bug.

Comment 13

[Chris Petersen]

Works for me in the Sept 14th Linux build.