330938 - Pressing Refresh on "multimedia" keyboard tries to reload chrome

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Rob Marshall [tH]]

I have a keyboard with a variety of useless buttons (Stop, Refresh, Back, Forward, etc.), and whilst Refresh works fine with a browser window focused, pressing it with any other window focused (Help viewer, Thunderbird[1], ChatZilla) makes the chrome reload and break in strange ways[2].

In the words of the assertion I got, "don't do that". ;)

[1] Tested Trunk 20060317 and 1.8 20060228
[2] http://bugs.rdmsoft.com/tbrefresh.png
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=TB16502999H

Comment 1

[Rob Marshall [tH]]

Attachment: add type check before touching webnav

This works, but I'm not sure if it's the best way...

Comment 2

[:Mook]

*** Bug 349306 has been marked as a duplicate of this bug. ***

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 215490 [details] [diff] [review]
add type check before touching webnav

Clearing review? since this will be fixed in Bug 360731.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

This should be fixed now.
Would be great if someone who has a keyboard with "Refresh" button could verify. Using Firefox, "Refresh" should always reload the current page.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Reload on my Natural Keyboard Pro worked fine when I tested your patch for 360731 previously (see my comment there).

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Ok, thanks.
Marking this one fixed.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Verified fixed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061201 Firefox/3.0a1