330990 - Support channel messages with user prefixes

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Samuel Sieb]

It's possible to send a msg or notice to @#channel for example.  Invite notifications are sent this way which is why they get dumped in the current channel instead of the channel the invite was for.

Comment 1

[James Ross]

FWIW, I've found out that the modes supported for these kinds of channel-subset messages are listed in the 005 flag STATUSMSG. http://www.irc.org/tech_docs/005.html mentions it in the table. There's also some relationship with WALLCHOPS, but I don't think it's worth validating anything with 005 in this particular case unless we run into problems.

Comment 2

[James Ross]

Attachment: Strip usermode prefix from notice/privmsg

This needed to rearrange the onNotice handler so that it took preference for channel notices over notices without a user. This means notices from the server to a channel will no go to that channel (with or without the usermode prefix), instead of just going to network.

The slightly odd return in the middle of the if/else if/else is needed, and I think is ok WRT code readability.

Comment 3

[Samuel Sieb]

Comment on attachment 227906 [details] [diff] [review]
Strip usermode prefix from notice/privmsg

> CIRCServer.prototype.onNotice =
> function serv_notice (e)
[...]
>+    if (e.params[2].search (/\x01.*\x01/i) != -1)
>     {
>         e.type = "ctcp-reply";
>         e.destMethod = "onCTCPReply";
>         e.set = "server";
>         e.destObject = this;
>         return true;

This return is unnecessary now.

> CIRCServer.prototype.onPrivmsg =
> function serv_privmsg (e)
[...]
>     /* setting replyTo provides a standard place to find the target for     */
>     /* replys associated with this event.                                   */

Not your comment, but replys -> replies.

Comment 4

[James Ross]

Checked in with changes --> FIXED.