347483 - 'this.userModes has no properties' connecting to moznet

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Andrew Schultz]

I get this error twice when connecting to moznet with current SeaMonkey trunk.  I don't see any noticeable symptoms.

cz: Error routing event server.notice: + message (string) 'this.userModes has no properties'
+ fileName (string) 'chrome://chatzilla/content/lib/js/irc.js'
+ lineNumber (number) 2292
+ stack (string) 275 chars
+ name (string) 'TypeError'
*
 in onNotice
TypeError: this.userModes has no properties
cz: serv_notice([object Object])@chrome://chatzilla/content/lib/js/irc.js:2292
ep_routeevent([object Object])@chrome://chatzilla/content/lib/js/events.js:238
ep_stepevents()@chrome://chatzilla/content/lib/js/events.js:306
mainStep()@chrome://chatzilla/content/static.js:1778

The parts of the code that would set userModes are executed later.  This is an apparent regression from bug 330990

Comment 1

[James Ross]

This will, I think, cause the dropping of all the notices sent before the first normal message during connection - hence, major security.

The code for setting up the userModes, and other stuff, waits for the 001 to initialise stuff (it doesn't init it when the server objects are created, as that'd be at application startup, which'd suck).

Correct solution would be to box in the prefix handling code in onNotice to not check if there's no userModes data - privmsgs shouldn't have the same issue, as they aren't sent before the 001, but could be protected likewise.

Comment 2

[James Ross]

Attachment: Only strip prefixes if we know what they are

Comment 3

[Samuel Sieb]

Comment on attachment 233368 [details] [diff] [review]
Only strip prefixes if we know what they are

Does userModes always exist?  If not, then please change it to avoid the warning.

Comment 4

[James Ross]

It does, it's just null until 001, which sets it to the defaults.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/extensions/irc/js/lib/irc.js&rev=1.98&mark=491#469

Comment 5

[James Ross]

Checked in --> FIXED.