use system smooth scrolling pref

NEW
Assigned to

Status

()

--
enhancement
13 years ago
4 years ago

People

(Reporter: jacob, Assigned: hwaara)

Tracking

(Blocks: 1 bug)

Trunk
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en) AppleWebKit/417.9 (KHTML, like Gecko) Safari/417.9.2
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.2) Gecko/20060319 Firefox/1.5.0.2

In OS X 10.4 (likely earlier), there is a "Use Smooth Scrolling" in System Preferences -> Appearance.

Firefox should probably use this instead of its "Use smooth scrolling" option.

The following can get this pref from the command line in 10.4:

$ defaults read .GlobalPreferences AppleScrollAnimationEnabled
1


Reproducible: Always

Comment 1

13 years ago
Related bug in Seamonkey : bug 236417.

Updated

13 years ago
Severity: minor → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 2

12 years ago
*** Bug 362377 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 3

12 years ago
Created attachment 247120 [details] [diff] [review]
Proposed fix

Here's a fix that makes the view code respect the system setting. It also removes the UI for the pref.  Roc, are you the right man for the review? I can have someone else look at the UI change if you want.
Attachment #247120 - Flags: review?(roc)
I'd prefer you to add this through nsILookAndFeel.
(Assignee)

Comment 5

12 years ago
Created attachment 247270 [details] [diff] [review]
Go through lookAndFeel instead

Something like this?
Attachment #247270 - Flags: superreview?(roc)
(Assignee)

Updated

12 years ago
Attachment #247120 - Attachment is obsolete: true
Attachment #247120 - Flags: review?(roc)
Attachment #247270 - Flags: superreview?(roc) → superreview+
Comment on attachment 247270 [details] [diff] [review]
Go through lookAndFeel instead

actually, one thing... you should make ShouldSmoothScroll be pure virtual in nsILookAndFeel, and add the default implementation of it to nsXPLookAndFeel.
Attachment #247270 - Flags: superreview+

Updated

12 years ago
Blocks: 362706
(Assignee)

Updated

12 years ago
Assignee: nobody → hwaara
(Assignee)

Comment 7

12 years ago
Created attachment 247480 [details] [diff] [review]
Patch v2

Ok, this implements the ShouldSmootScroll() method in nsXPLookAndFeel as suggested in the last comment.

Mano, please see the browser/ change.
Attachment #247270 - Attachment is obsolete: true
Attachment #247480 - Flags: superreview?(roc)
Attachment #247480 - Flags: review?(mano)
One more thing. Can you update NS_ILOOKANDFEEL_IID to a new IID? Thanks.
Comment on attachment 247480 [details] [diff] [review]
Patch v2

This abuses nsILookAndFeel IMO. We should rather handle this the way other system-based prefs are handled, i.e. rely on the system preference only if it is not overridden. In other words, you should use the GetMetric system, see bug 187508 for example.
Attachment #247480 - Flags: review?(mano) → review-
(Assignee)

Comment 10

12 years ago
(In reply to comment #9)
> (From update of attachment 247480 [details] [diff] [review] [edit])
> This abuses nsILookAndFeel IMO. We should rather handle this the way other
> system-based prefs are handled, i.e. rely on the system preference only if it
> is not overridden. In other words, you should use the GetMetric system, see bug
> 187508 for example.

Abuses how? I don't see why this matters. We just need to return the boolean in one way or another, and I did it on Roc's suggestion. 

Mac overrides with the system pref, other platforms that don't have a native pref for this continue like before, which is the change this bug suggests.
You should be able to override the system pref from about:config by adding the pref manually, see how GetMetric works.

Updated

5 years ago
Component: Shell Integration → Widget: Cocoa
Product: Firefox → Core
Hardware: PowerPC → All
Version: unspecified → Trunk

Comment 12

5 years ago
This should not negatively affect Bug 964097 (though that's unlikely). Bug 640663 is about a somehow related OS X scrolling issue.
See Also: → bug 964097, bug 640663
You need to log in before you can comment on or make changes to this bug.