331143 - sanitize new search format

Status: RESOLVED FIXED

(Firefox :: Search, defect, P2)

Description

[Axel Hecht [:Pike]]

bug 317107 comment 34 says:

>> I appreciate Axel's point about there being confusion and likely errors on the
>> part of localizers when creating these files. The best way to avoid that is to:
>> 
>> - use strict namespace checking in the search service and pro-actively throw
>> exceptions when there are failures
>> - use a namespace prefix on the root, e.g.
>> 
>> <moz:SearchPlugin xmlns:moz="http://www.mozilla.org/2006/browser/search/"
>> xmlns="http://a9.com/-/spec/opensearchdescription/1.1/">
>>   <ShortName>Amazon.com</ShortName>
>>   ...
>>   <moz:Alias>am</moz:Alias>
>> </moz:SearchPlugin>
>> 
>> since this is what people copy from, and it makes it clear what our extensions
>> are.
>
> If you don't have any objection I'd rather leave the format as is for now -
> making ours be the default namespace simplifies checking which type of plugin
> we're dealing with. This can be revisited for a2.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

I'd really love to just use OpenSearch and forget about this almost-OpenSearch stuff.

Comment 2

[Mike Connor [:mconnor]]

Cleanup is b1, we need to get features implemented for testing/iteration first.  I know the l10n people won't love this, but b1 should still give them months.

Comment 3

[Axel Hecht [:Pike]]

With search suggest we do have an extension to OS that warrants the introduction
of a mozilla namespace into the search plugin, so I'd take down in writing the 
outcome of a discussion that gavin and I had a while back which was that we'd like
to have one namespace, and it'd be fine to just drop the OS one from our plugin
and have the parser for search xml engines accept the OS namespace in addition to
the mozilla one.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: remove the extra namespace

This simplifies the file format, and the parser doesn't care since it just checks localNames.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Checked in branch and trunk!