331145 - Tooltip for task without due date is not displayed and causes javascript error

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Stefan Sitter [:ssitter]]

Tooltip for task without due date is not displayed and causes javascript error

Steps to Reproduce:
1) Create a new task and specify start date but no due date
2) Hover mouse pointer over task item in task pane -> tooltip is displayed, OK
3) Switch to multiweek or month view
4) Enable menu option View -> Tasks in View
5) Hover mouse pointer over task item in multiweek or month view

Actual Results:
No tooltip is displayed. JavaScript console shows the following error:

    Error: occurrence.dueDate has no properties
    Source File: chrome://calendar/content/mouseoverPreviews.js
    Line: 73

Expected Results:
A tooltip is displayed showing task details.

Additional Information:
If you specify a due date the tooltip is displayed but shows only start date.

Tested with Sunbird 0.3a1+ (20060320) build.

Comment 1

[Joey Minta]

Might be best to wait on this until after Bug 322768.  Moving away from jsDate, as that bug helps us do, will make it easier to handle null-cases.

Comment 2

[Joey Minta]

Attachment: more jsdate killing

This patch fixes the above error by moving mouseoverPreviews away from jsDate to calDateTime.  This required also fixing getCurrentNextOrPreviousOccurrence to similarly stop using jsDate.  I also removed the code referring to eventStart and eventEnd, since those variables never seemed to be used anywhere!

Comment 3

[Joey Minta]

*** Bug 333745 has been marked as a duplicate of this bug. ***

Comment 4

[Stefan Sitter [:ssitter]]

Comment on attachment 221498 [details] [diff] [review]
more jsdate killing

From a quick test with this patch: The tooltips work nice with different kinds of normal events/tasks. The only minor issue I saw was with a single-all-day event, where the tooltip was like "03.08.2006 - "

Comment 5

[Joey Minta]

Attachment: more jsdate killing v2

Patch updated to include a fix for ssitter's testing comment.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 232782 [details] [diff] [review]
more jsdate killing v2

r=mvl

Comment 7

[Joey Minta]

Patch checked in.

Comment 8

[Sebastian Schwieger]

Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060828 Calendar/0.3a2+

Comment 9

[Stefan Sitter [:ssitter]]

VERIFIED with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1)
Gecko/20060901 Calendar/0.3a2+