335159 - Print: Line break is shown as escaped <BR> after HTML export

Status: VERIFIED FIXED

(Calendar :: Internal Components, defect)

Description

[Damian Szczepanik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2

end of line is visible as <BR> on print preview and printed paper

Reproducible: Always

Steps to Reproduce:
1. create new event, description must include end of line sign (just press enter), eg:

first line [ENTER]
second line

2. print event

Comment 1

[Damian Szczepanik]

Attachment: screenshot

Comment 2

[Stefan Sitter [:ssitter]]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060426 Mozilla Sunbird/0.3a1+.

A line break (e.g. in description field) is converted to <br> tag during html export for printing. But this tag is than escaped to &lt;br&gt; resulting in the visible <br> and not the expected break.

Comment 3

[Reed Loden [:reed]]

The bugspam monkeys have struck again. They are currently chewing on default assignees for Calendar. Be afraid for your sanity!

Comment 4

[Joey Minta]

I can't really fix this until e4x gets its act together (bug 331145).

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

jminta: bug 331145 doesn't appear to be about e4x.  Is that really the bug # you intended?

Comment 6

[Joey Minta]

(In reply to comment #5)
> jminta: bug 331145 doesn't appear to be about e4x.  Is that really the bug #
> you intended?
> 
I promise to learn how to use mac keyboards.  Bug 336921 was the number that should have been copied.

Comment 7

[Joey Minta]

Attachment: actually append children, don't replace

The original code included the quoted <BR>, when really we should be appending a new <br/> child for each line.  (Note that this patch will look weird in branch builds until the blocking bug lands 1.8)  mrbkap said he *badly* wanted to see this patch, so I'm asking him for first-review.

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 230829 [details] [diff] [review]
actually append children, don't replace

>+                var lines = desc.split('\n');
>+                for each (var line in lines) {
>+                    descnode.div[1].appendChild(line);
>+                    if (line != lines[lines.length]) {
That seems to be asking for trouble. What if one line happens to be equal to the last line?
You really want to use the good old index-based for-loop, so you can simply compare the index of the line with the length.

Comment 9

[Joey Minta]

Attachment: append children, v2

Carrying forward first review, patch updated to reflect previous comments.

Comment 10

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 231456 [details] [diff] [review]
append children, v2

r=mvl

Comment 11

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk

-> FIXED

Comment 12

[Damian Szczepanik]

verified, works prity good