Closed
Bug 331165
Opened 19 years ago
Closed 16 years ago
nsID::ToString should use NS_Alloc instead of PR_Malloc
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: darin.moz, Assigned: neil)
References
Details
Attachments
(1 file)
|
913 bytes,
patch
|
benjamin
:
review+
benjamin
:
superreview+
|
Details | Diff | Splinter Review |
nsID::ToString should use NS_Alloc instead of PR_Malloc
I think the XPCOM glue should use the XPCOM allocator instead of the NSPR equivalents. Or, we should document somewhere that they are the same.
It might be nice if we had a version of nsID::ToString that operated on a nsACString.
|
Assignee | |
Comment 1•16 years ago
|
||
So far I only found one caller (nsImportModule.cpp), which uses NS_Free...
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #368356 -
Flags: superreview?(benjamin)
Attachment #368356 -
Flags: review?(benjamin)
|
||
Updated•16 years ago
|
Attachment #368356 -
Flags: superreview?(benjamin)
Attachment #368356 -
Flags: superreview+
Attachment #368356 -
Flags: review?(benjamin)
Attachment #368356 -
Flags: review+
|
|
Assignee | |
Comment 2•16 years ago
|
||
Pushed changeset 6be239399910 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 4•16 years ago
|
||
See bug 392526 for the follow-up on converting the callers to use NS_Free() in some way or other.
Also, we can revert bug 411256 now, right?
You need to log in
before you can comment on or make changes to this bug.
Description
•