Closed Bug 331215 Opened 18 years ago Closed 17 years ago

Find toolbar doesn't reset status when search is wrapped

Categories

(Toolkit :: Find Toolbar, defect, P3)

Product:
Toolkit
Component:
Find Toolbar
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha2

People

(Reporter: ecfbugzilla, Assigned: asaf)

References

Details

Attachments

(2 files, 1 obsolete file)

patch
1.18 KB, patch
Gavin
: review+
Details | Diff | Splinter Review
unit test for checkin
6.71 KB, patch
Details | Diff | Splinter Review 
How to reproduce this problem:
1. Go to https://bugzilla.mozilla.org/
2. Press Ctrl-F to open search toolbar
3. enter "test" - the word "latest" gets highlighted
4. now move to the beginning of the search field and add the letters "la"

Result: after adding the second letter the word "latest" is found again, the text "reached end of text, continued from top" is displayed, but the input field stays red. It should be white instead, as is the case when the letters "la" are added in reverse order.

Seeing this with in:
Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Windows NT 5.1; en-US; rv:1.8) Gecko/20060317 Firefox/2.0a1
Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060309 Firefox/1.6a1
Attached patch patch — — Splinter Review 
Assignee: nobody → mano
Status: NEW → ASSIGNED

        Attachment #247008 -
        Flags: review?(gavin.sharp)

    
  
Priority: -- → P3
Target Milestone: --- → Firefox 3 alpha2

        Attachment #247008 -
        Flags: review?(gavin.sharp) → review+

    
    

    
  
mozilla/toolkit/content/widgets/findbar.xml 1.3
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED

    
    

    
  
tbd: unit test.
Flags: in-testsuite?

    
    

    
  

      
      
      
      

        Attached file
          
        unit test (obsolete)
        — 
      

    


  

        Attachment #247582 -
        Flags: review?(gavin.sharp)

    
    

    
  
Comment on attachment 247582 [details]
unit test

nit: space after "after" in both ASSERT strings.

        Attachment #247582 -
        Flags: review?(gavin.sharp) → review+

    
    

    
  
Gavin, you probably meant <before "after"> :)

    
    

    
  


  

        Attachment #247582 -
        Attachment is obsolete: true

    
    

    
  
mozilla/toolkit/content/tests/chrome/Makefile.in 1.4
mozilla/toolkit/content/tests/chrome/bug331215_window.xul initial revision: 1.1
mozilla/toolkit/content/tests/chrome/test_bug331215.xul initial revision: 1.1
Flags: in-testsuite? → in-testsuite+

    
  
Blocks: 443493
Product: Firefox → Toolkit

          You need to log in
          before you can comment on or make changes to this bug.