336337 - patrocles thunderbird build is using an old platform sdk

Status: VERIFIED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Darin Fisher]

patrocles thunderbird build is using an old platform sdk

http://developer.mozilla.org/en/docs/Windows_Build_Prerequisites#Platform_SDK

this is causing build bustage.  i'm going to hack around it for now, but i think in general we should be satisfying the build prereqs on our build systems ;-)

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Is this caused by bug 331433?

Comment 2

[Stefan Sitter [:ssitter]]

Is there a reason why Thunderbird (trunk) is still build with VC6? 
If no, is there an schedule for upgrade?
This might be the cause for Bug 343053 because Lightning is build with VC8 now.

Comment 3

[Yuri Kovalchuk]

From http://developer.mozilla.org/en/docs/Windows_Build_Prerequisites#Platform_SDK
"...VC6 is not supported and will produce unusable builds". 
Also would like to know why Thunderbird is built with VC6 and no SDK?

Comment 4

[Robert Helmer [:rhelmer]]

We are actively moving all the older tinderboxes to standard reference build platforms (see the dependency, bug 334456, for details).

Moving to a reference platform also ensures that we are satisfying our own documented build prereqs, as Darin mentions in comment 1 :) This is of critical importance to us. The current tinderbox farm is very ad-hoc, which is understandable since these machines have gone through some turbulent times.

Also, we are talking about 30-40 build machines (http://wiki.mozilla.org/Build:Farm) most of which are in random configurations as far as OS/toolchain go, so we need to prioritize by what is shipping sooner, or other good criteria. Doing them all at once is not reasonable from a resource standpoint, and taking them all down while we bring up new ones is unacceptable due to the project's dependence on them.

We'd rather spend time moving builds to a known-good OS and toolchain combo, on reliable hardware, than trying to fix the current installations.. the former is reproducable and therefore automatable while the latter is not.

Finally, we have been blocking on the colo move, which is happening this weekend.

Comment 5

[Yuri Kovalchuk]

Can some one tell what version of the platform sdk is used on patrocles. I tried to build with plain VC6 but it failed somewhere in gfx module. But it is building fine with 2003 PSDK on VC6.
Need  to reproduce this to fix bug #267426.

Comment 6

[Yuri Kovalchuk]

Is there any way I can help with this bug?

Comment 7

[Jungshik Shin]

strsafe.h is not available on patrocles because it uses an old platform sdk, which caused a bustage after landing the patch for bug 344630. I backed it out for now, 

Comment 8

[Robert Helmer [:rhelmer]]

We've set up a new tinderbox to replace patrocles - tb-win32-tbox.
This is based on the latest ref. platform with VC8 - does this also fix 331433 then?

Comment 9

[Scott MacGregor]

Rob, can we throw the switch on the new thunderbird trunk tinderbox machine?

Comment 10

[Robert Helmer [:rhelmer]]

(In reply to comment #9)
> Rob, can we throw the switch on the new thunderbird trunk tinderbox machine?

The new machine is running, published a nightly build here:
http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/experimental//2006-10-25-03-trunk/

Let me know if it looks ok, and we can disable patrocles and turn on update generation on the new box (tb-win32-tbox).

Comment 11

[Mike Cowperthwaite]

I tried getting today's build from the 'experimental' and I'm getting the DLL Not Found error for MSVCR80.dll.  (I'm running Windows 2000 with no MSVC installed.)  I'm sure I can locate the DLLs easily, but is this how you want to distribute these builds?  (Sorry if this question is addressed elsewhere.)

Comment 12

[Stuart Parmenter]

thunderbird probably needs the same manifest stuff that firefox had to go through...  bsmedberg?

Comment 13

[Benjamin Smedberg]

ted, please? ;-) This may just need the MSVC runtime files added to the packages-static file.

Comment 14

[Robert Helmer [:rhelmer]]

Attachment: push to nightly dir, enable updates

Paul, I went ahead and checked this in, but I'd like to get a review from you regardless; this config is identical to patrocles, with the exception of the headers and the location of "blat".

Comment 15

[(not currently active) Ted Mielczarek]

I don't have any cycles for this right now, but if it's just not redistributing the CRT DLLs then that should be an easy fix.

Comment 16

[(not currently active) Ted Mielczarek]

bug 358912 fixed the redist stuff.

Comment 17

[(not currently active) Ted Mielczarek]

Attachment: Package VC8 redist in thunderbird installer

Ok, I was wrong on both counts.  That bug fixed a Fx tinderbox issue.  I don't have the time or the means to test this patch, but it's just a copy/paste from Firefox's installer anyway.  It should get you the VC8 redist files packaged into the installer.

Comment 18

[Scott MacGregor]

Comment on attachment 244293 [details] [diff] [review]
Package VC8 redist in thunderbird installer

This looks good based on what I see for Bug 324690 for Firefox. Thanks Ted.

I wonder if the build team needs to make the same config change in Bug 358912 for the new Thunderbird build machine.

Comment 19

[(not currently active) Ted Mielczarek]

Comment on attachment 244293 [details] [diff] [review]
Package VC8 redist in thunderbird installer

Checked in.  Someone from the build team should verify that WIN32_REDIST_DIR is set on this tinderbox.

Comment 20

[(not currently active) Ted Mielczarek]

tb-win32-tbox still needs WIN32_REDIST_DIR set:
http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1162450860.20094.gz&fulltext=1

Comment 21

[Robert Helmer [:rhelmer]]

WIN32_REDIST_DIR is now set on tb-win32-tbox. Please reopen if tonight's build still has the problem, or mark verified if it does not. Thanks!