Closed Bug 331487 Opened 19 years ago Closed 17 years ago

Fix GROUP_BY_FOLDER in query system


(Firefox :: Bookmarks & History, defect, P3)






(Reporter: brettw, Assigned: ondrej)




(1 file)

The current query system doesn't do anything with GROUP_BY_FOLDER. It just assumes for bookmark queries that you want folders, and for history queries you don't. The only thing this option would help is for nested tags if you want all items in the folder and it's descendents to appear in a flat list. Apparently we aren't supporting this, so we can remove this flag.
Priority: -- → P2
Target Milestone: --- → Firefox 2 alpha2
Depends on: 317830
Whiteboard: swag: 0d (part of 317830)
Target Milestone: Firefox 2 alpha2 → Firefox 2 beta1
Attached patch partial workSplinter Review
This doesn't work, but is a straw man of a group by folder impl.
Summary: Remove GROUP_BY_FOLDER from query system → Fix GROUP_BY_FOLDER from query system
Whiteboard: swag: 0d (part of 317830) → swag: ???d
Note: we should also make sure using multiple folders in the query gives the same results.
Priority: P2 → P3
Summary: Fix GROUP_BY_FOLDER from query system → Fix GROUP_BY_FOLDER in query system
Whiteboard: swag: ???d → swag: 2d
Target Milestone: Firefox 2 beta1 → Firefox 3 alpha2
Assignee: brettw → nobody
should resolve this asap, before B1 which is likely when extension developers will really start to flex this stuff.
No longer depends on: 317830
Target Milestone: Firefox 3 alpha2 → Firefox 3 alpha6
Whiteboard: swag: 2d
Target Milestone: Firefox 3 alpha6 → Firefox 3 beta1
Target Milestone: Firefox 3 M7 → Firefox 3 M8
making this a tracker for the other GROUP_BY_FOLDER bugs.
Depends on: 369657, 369658, 378799
Target Milestone: Firefox 3 M8 → Firefox 3 M9
Target Milestone: Firefox 3 M9 → Firefox 3 M10
B1 is out, and still not fixed. In my extension i need to recursively get all folders as i want to show all bookmarks in a flat list. It would be nice, if this wouldn't be needed.
Target Milestone: Firefox 3 M10 → Firefox 3 M11
I just want to remind that with bug 385245 all the other groupings will be removed (if patch gets approved). I have now checked that GROUP_BY_FOLDER is only used for the "Recent Tags" query in "Smart Bookmarks". So I will try to remove the last grouping using the mentioned bug.
Bug 385245 has been finished and is waiting for review. Grouping was completely replaced with queries. 
Assignee: nobody → ondrej
Depends on: 385245
Target Milestone: Firefox 3 beta3 → ---
GROUP_BY_FOLDER has gone with bug 385245, the bug is invalid now.
Closed: 17 years ago
Resolution: --- → INVALID
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.