background painting and scrollbar code should use nsHTMLDocument::GetBody directly

RESOLVED FIXED in mozilla1.9beta4

Status

()

Product:
Core
Component:
CSS Parsing and Computation
P2
normal
RESOLVED FIXED
Reported:
12 years ago
Modified:
10 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({perf})

Version:
Trunk
Target:
mozilla1.9beta4
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch])

Attachments

(1 attachment, 2 obsolete attachments)

patch
5.45 KB, patch
sicking
: review+
sicking
: superreview+
Mike Schroepfer
: approval1.9+
Details | Diff | Splinter Review
(Assignee)

Description

•
12 years ago 
Sicking points out that nsHTMLDocument::GetBody can be slow; we should expose GetBodyContent and use it in the places where background painting and scrollframes care about the <body> only (not framesets!).
 (Assignee)

Comment 1

•
12 years ago 
Created attachment 216069 [details] [diff] [review]
untested patch

Untested patch (no longer applies to trunk due to sicking's backout).
 (Assignee)

Updated

•
12 years ago
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [patch]
Target Milestone: --- → mozilla1.9alpha
 (Assignee)

Updated

•
12 years ago
Attachment #216069 - Flags: superreview?(jst)
Attachment #216069 - Flags: review?(bugmail)

Comment 2

•
12 years ago 
Comment on attachment 216069 [details] [diff] [review]
untested patch

sr=jst
Attachment #216069 - Flags: superreview?(jst) → superreview+
 (Assignee)

Updated

•
11 years ago
QA Contact: ian → style-system
 (Assignee)

Comment 3

•
10 years ago 
Created attachment 303678 [details] [diff] [review]
patch

Fixing bug 379461 reminded me of this patch that I had in my tree, so I updated it.  I chose to name the new function GetBodyContentExternal this time, since it led to a smaller patch and it reduces the risk of future callers accidentally caling the slow virtual function when they could avoid it.
Attachment #216069 - Attachment is obsolete: true
Attachment #303678 - Flags: superreview?(jonas)
Attachment #303678 - Flags: review?(jonas)
 (Assignee)

Updated

•
10 years ago
Attachment #303678 - Flags: superreview?(jonas)
Attachment #303678 - Flags: review?(jonas)
 (Assignee)

Comment 4

•
10 years ago 
Created attachment 303684 [details] [diff] [review]
patch

This one actually works, now that I found I needed to manually modify htmldocument.gqi (UGH!  filed bug 417892).
Attachment #303678 - Attachment is obsolete: true
Attachment #303684 - Flags: superreview?(jonas)
Attachment #303684 - Flags: review?(jonas)
Attachment #303684 - Flags: superreview?(jonas)
Attachment #303684 - Flags: superreview+
Attachment #303684 - Flags: review?(jonas)
Attachment #303684 - Flags: review+
 (Assignee)

Comment 5

•
10 years ago 
Comment on attachment 303684 [details] [diff] [review]
patch

Simple performance patch (low risk) that I've had lying around for a long time.
Attachment #303684 - Flags: approval1.9?

Updated

•
10 years ago
Attachment #303684 - Flags: approval1.9? → approval1.9+
 (Assignee)

Comment 6

•
10 years ago 
Checked in 2008-02-19 08:48 -0800, mostly backed out 2008-02-19 09:28 -0800 since I needed to back out bug 379461 (which this applied on top of) due to reftest failures, and relanded 2008-02-19 10:47 -0800.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9alpha1 → mozilla1.9beta4
You need to log in before you can comment on or make changes to this bug.