331616 - XML Parsing Error popup when dbl-click on line copied from web

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[LeeF]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060214 Camino/1.0
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060214 Camino/1.0

Copied text from above url [using Camino] into email, then dbl-clicked on the green dashed line. Got popup  XML Parsing Error: undefined entity
Location: chrome://editor/content/EdFormProps.xul
Line number 44, column 1:
<dialog title="&windowTitle.label;"
^


Reproducible: Always

Steps to Reproduce:
1. copy first 2 paragraphs of text from above url into a html email
2. dbl-click on green dashed line
3.

Actual Results:  
could not do any more editing with that email window. could not close it. could minimize it and move it around. could not quit Thunderbird. had to Force Quit. 

Expected Results:  
at least let me trash that email and start a new one. at least Quit when told to.

I have no add-ons, just out-of-the box TBird.
Green line did not appear on the web page but did appear when text copied to email. As long as I didn't mess with the green lines everything was fine.

Comment 1

[LeeF]

Attachment: snapshot of email window with error popup

.tiff file

Comment 2

[Marek Stępień [:marcoos, inactive]]

This is because form elements are not supported in Thunderbird's fork of Editor.

The XUL files link to non-existent DTDs.

Simpler steps to reproduce:

1. From the menu: Insert > HTML
2. Enter: "<textarea></textarea>" or "<form method='get'><input value='foo'/></form>"
3. Double-click the textarea or the input box

Actual results:
1. XML Parsing error

Expected results:
1. Either don't show anything (fail silently), or display a non-broken version of  EdTextAreaProps.xul  or EdInputProps.xul.

Comment 3

[Marek Stępień [:marcoos, inactive]]

Attachment: Patch for Tb2: silently fail when double-clicking form elements

For Tb 2, the only solution not breaking the l10n freeze, is to make form elements just do nothing when double-clicked.

I'm just commenting out the respective doCommand functions in ComposerCommands.js.

Comment 4

[Marek Stępień [:marcoos, inactive]]

Actually, we have the DTD files in CVS, they're just not shipped with Tb.
After adding them manually to comm.jar, this works.
So we have an alternative solution - just ship these DTDs with Thunderbird (localizers should have already translated them, at least we did that for 'pl')

EditorButtonProperties.dtd
EditorFieldSetProperties.dtd
EditorFormProperties.dtd
EditorInputProperties.dtd
EditorLabelProperties.dtd
EditorTextAreaProperties.dtd
EditorSelectProperties.dtd

Comment 5

[Marek Stępień [:marcoos, inactive]]

Attachment: Ship the form-related DTDs with Tb

This is the better solution - ship the missing DTDs.

Comment 6

[Marek Stępień [:marcoos, inactive]]

Pike, what do you think about comment 4 and comment 5?

Comment 7

[Hubert Gajewski]

blocking‑thunderbird2=?

Comment 8

[Scott MacGregor]

Yeah, we should package those existing localized files in Thunderbird. I'm not sure why they are currently treated as suite only. I'll land this on the trunk and the branch. Thanks for the patch Marek!

Comment 9

[Scott MacGregor]

Comment on attachment 257237 [details] [diff] [review]
Ship the form-related DTDs with Tb

I did a quick search through lxr on one of the files and verified that it existed in all of the locales we have for Thunderbird.

Comment 10

[Axel Hecht [:Pike]]

I'd call adding non-used strings to the build at least semi-string-freeze-breaking.

A short glance at EditorFormProperties.dtd looks like most of them are translated, but we should get an announcement of this. Having some sorts of QA howto for the exposed strings would be great, so that localizers can actually test their strings.

Comment 11

[Marek Stępień [:marcoos, inactive]]

I just checked the tinderboxen and I can verify that no locale has been broken because of this check-in.

I'll post to .l10n shortly about how to QA this.

Comment 12

[Marek Stępień [:marcoos, inactive]]

Verified with  2.0pre (20070304)