331781 - Please don't build chromelist.txt files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.8.0.1) Gecko/20060313 Debian/1.5.dfsg+1.5.0.1-4 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ja-JP; rv:1.8.0.1) Gecko/20060313 Debian/1.5.dfsg+1.5.0.1-4 Firefox/1.5.0.1

With recent changes to how chrome works, chromelist.txt files are useless.
Patch following.

Reproducible: Always

Comment 1

[Mike Hommey [:glandium]]

Attachment: Patch

Comment 2

[Mike Hommey [:glandium]]

(Making the summary more understandable)

Comment 3

[Benjamin Smedberg]

Comment on attachment 216332 [details] [diff] [review]
Patch

Sounds like we should remove the make-chromelist.pl script also.

Comment 4

[Benjamin Smedberg]

Fixed on trunk.

Comment 5

[Serge Gautherie (:sgautherie)]

*** Bug 301825 has been marked as a duplicate of this bug. ***

Comment 6

[[e-mail]]

I was actually poking at make-chromelist.pl to get it back into shape
(the first step of course was to preprocess the input).

Comment 7

[[e-mail]]

Attachment: Restore and fix chromelist.txt

Note: I really wanted to #ifndef MOZ_XUL_APP this, but couldn't figure out how.

Comment 8

[[e-mail]]

Attachment: Diff against original version

Comment 9

[John Mellor (Jomel)]

Removing chromelist.txt severely limits gerv's Patch Maker (http://www.gerv.net/software/patch-maker) - a tool designed specifically to help people create patches to mozilla chrome.

Comment 10

[Benjamin Smedberg]

Comment on attachment 216830 [details] [diff] [review]
Diff against original version

Neil, I'm not convinced that chromelist.txt (or gerv's patchmaker) have much value in the face of preprocessed chrome and multiple locale repositories and whatnot; do you think otherwise?

Comment 11

[Benjamin Smedberg]

Comment on attachment 216830 [details] [diff] [review]
Diff against original version

Cancelling review until discussion is resolved.

Comment 12

[[e-mail]]

(In reply to comment #10)
>Neil, I'm not convinced that chromelist.txt (or gerv's patchmaker) have much
>value in the face of preprocessed chrome and multiple locale repositories and
>whatnot; do you think otherwise?
Very little of SeaMonkey's chrome is preprocessed. And patchmaker users can always patch an en-US build. And I need a CC to see bugzilla comments (unfortunately there's no CC me option when attaching a patch).

Comment 13

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20060502 SeaMonkey/1.1a] (nightly) (W98SE)

On one hand, I was about to request approval‑branch‑1.8.1 for the removal patch;
on the other hand, I'm still using gerv's patchmaker, even if I use it with cvs and thus don't need the chromelist.txt file anymore...

Could you agree on one way or the other ?