Closed Bug 331788 Opened 14 years ago Closed 14 years ago

CalExt-only files should not be packaged in calendar/resources/jar.mn when Sunbird is built

Categories

(Calendar :: Internal Components, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sipaq, Assigned: sipaq)

Details

Attachments

(1 file, 1 obsolete file)

As discussed with mvl on IRC I'm putting this into a bug for future reference.

http://lxr.mozilla.org/seamonkey/source/calendar/resources/jar.mn#109 should move into the #ifndef MOZ_SUNBIRD block since it will be overridden during the build process by calendar/sunbird/themes/[w/p]instripe/sunbird anyway.
Attached patch Patch v1 (obsolete) — Splinter Review
jminta already gave r+ via IRC.
Attachment #216337 - Flags: first-review+
Add to the list the following files in both *instripe themes:

calendarviews.css
pageupdown.png
prevnextarrow.png
datetimepickers/minimonth.css
> calendarviews.css

I don't see this used in calendar/resources/jar.mn

> pageupdown.png

Same here.

> prevnextarrow.png
> datetimepickers/minimonth.css

Here you are right.
Status: NEW → ASSIGNED
Attached patch Patch v2Splinter Review
Patch incorporates some of lilmatt's suggestions.
Attachment #216337 - Attachment is obsolete: true
Attachment #216338 - Flags: first-review?(jminta)
Summary: calendar.css should not be packaged in calendar/resources/jar.mn when Sunbird is built → CalExt-only files should not be packaged in calendar/resources/jar.mn when Sunbird is built
Comment on attachment 216338 [details] [diff] [review]
Patch v2

r=jminta  Now my build will finish in 59:59.90 instead of 1 hour. :-)  Gonna hold off on landing this until post 0.3a2, since it's non-zero risk for very little gain.  Please ping me about it then.
Attachment #216338 - Flags: first-review?(jminta) → first-review+
Sorry for the confusion.
calendarviews.css and pageupdown.png are actually in both themes directories, however they aren't in jar.mn
(In reply to comment #6)
> Sorry for the confusion.
> calendarviews.css and pageupdown.png are actually in both themes directories,
> however they aren't in jar.mn
> 
calendarviews.css became obsolete at the switch to the new views.
>> calendarviews.css and pageupdown.png are actually in both themes directories,
>> however they aren't in jar.mn
>> 
> calendarviews.css became obsolete at the switch to the new views.

Shouldn't we just cvs remove those two files (pageupdown.png and calendar-views.css) in Sunbird Pinstripe and Winstripe?
(In reply to comment #8)
> Shouldn't we just cvs remove those two files (pageupdown.png and
> calendar-views.css) in Sunbird Pinstripe and Winstripe?

I'd say so. From what I can see, we don't use pageupdown.png in the new themes at all. 

Whiteboard: [needs landing]
Patch checked in on trunk and MOZILLA_1_8_BRANCH
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in before you can comment on or make changes to this bug.