331856 - Middle-clicking Bookmarks Toolbar / non-bookmark items in Bookmarks menu opens all bookmarks in tabs

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[John Hanna]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060326 Firefox/2.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060326 Firefox/2.0a1

Middleclick in any spare space on that toolbar (ie not on a bookmark) and it will launch bookmarks in tabs and in popup windows.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20060326 Firefox/2.0a1 ID:2006032702 

Reproducible: Always

Steps to Reproduce:
1.View -> Toolbars ->Bookmarks Toolbar
2.Middle click ( MOuse wheel) on any unused part of that toolbar
3.

Actual Results:  
This single Middle Click opened multiple tabs, some real and some empty and multiple popups. It seems that for every pop up it also spawns a empty tab

Expected Results:  
Didn't expect any such "Middler Click" behaviour

Comment 1

[Phil Ringnalda (:philor)]

Were those popups and tabs the same thing you would get by right-clicking empty space on the toolbar and selecting "Open in Tabs," maybe from having lots of bookmarklets to open the popups? That (rather unexpected) behavior, opening all the bookmarks that are children of the toolbar, is what I get from middle clicking empty space.

Comment 2

[John Hanna]

(In reply to comment #1)
> Were those popups and tabs the same thing you would get by right-clicking empty
> space on the toolbar and selecting "Open in Tabs," maybe from having lots of
> bookmarklets to open the popups? That (rather unexpected) behavior, opening all
> the bookmarks that are children of the toolbar, is what I get from middle
> clicking empty space.
> 
Phil, yes the result is identical.
I have EIGHT Bookmarklets/Bookmarks and 5 generate a pop up window as they are designed to do, but why do I then have to also close 5 EMPTY tabs for each of those pop ups. If I activate a single pop up Bookmark by clicking on it, there is no accompanying empty tab generated for the tab bar.

Comment 3

[Phil Ringnalda (:philor)]

Lame behavior for bookmarklets redirected to new tabs is bug 55696 or bug 251137 depending on which way you tilt your head.

What's newly interesting is that middle-clicking the toolbar is treated like you middle-clicked the parent folder, which doesn't happen in non-Places. Together with bug 332260, that makes me think that any middle-click that isn't on something recognized is treated as a middle-click on the parent, which is likely to blow up with things like extensions adding menu items.

Comment 4

[Wesley Johnston (:wesj)]

This bug can result in a lot of pseudo-dataloss, as all the tabs you had open before are erased for the new ones. Can we bump the severity?

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

*** Bug 332260 has been marked as a duplicate of this bug. ***

Comment 6

[Nickolay_Ponomarev]

Morphing the bug to include the case when the click happens on an item in the Bookmarks menu (such as Organize Bookmarks, Subscribe, Bookmark this page, etc)

Places impl that needs fixing:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser-places.js&rev=1.7#299

Here's the old bookmarks code that deals with non-bookmark items correctly:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/bookmarks/content/bookmarksMenu.js&rev=1.56#440

Comment 7

[Brian Polidoro]

*** Bug 344740 has been marked as a duplicate of this bug. ***

Comment 8

[Michael Ventnor]

This bug is even more serious. In latest nightly when you middle click space on the bookmark toolbar it closes all the tabs and opens Firefox Central. Requesting blocking.

Comment 9

[Nickolay_Ponomarev]

Michael: Er, this is a Places bug, which is disabled on Fx2 branch. If you see a similar bug on the Fx2 branch, please search for/open another bug.

Setting version to trunk to avoid confusion.

Comment 10

[Michael Ventnor]

(In reply to comment #9)
> Michael: Er, this is a Places bug, which is disabled on Fx2 branch. If you see
> a similar bug on the Fx2 branch, please search for/open another bug.
> 
> Setting version to trunk to avoid confusion.
> 

Is it a places bug? Erm, oops. :/ I guess Places still has a LOOOONG way to go.

Comment 11

[Asaf Romano (gone)]

Attachment: patch

This also fixes middle-click behavior for bookmarks on the places toolbar not to open in background.

Comment 12

[(not reading, please use [e-mail] instead)]

Comment on attachment 250990 [details] [diff] [review]
patch

r=sspitzer

Comment 13

[Asaf Romano (gone)]

mozilla/browser/base/content/browser-places.js 1.18

Comment 14

[pal-moz]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070512 Minefield/3.0a5pre ID:2007051204 [cairo][places]

1) middle-click on space in bookmarks toolbar
2) no response

reopen ?

Comment 15

[pal-moz]

Attachment: screenshot

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007102516 Minefield/3.0a9pre ID:2007102516

middle-click space on Bookmarks Toolbar.
Assertion Failed window appears, see screenshot.

should be re-open this bug.

Comment 16

[pal-moz]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008022204 Minefield/3.0b4pre ID:2008022204

no assertion failed error now.


BTW, is this an intended behavior ?
1) middle-click on space in bookmarks toolbar
2) no response (nothing open in tabs)

Comment 17

[Asaf Romano (gone)]

Yes.

Comment 18

[pal-moz]

thanks.

Comment 19

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv