Closed Bug 366474 Opened 18 years ago Closed 18 years ago

rootNodeIsSelected is not reliable for the menu view

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 alpha2

People

(Reporter: asaf, Assigned: asaf)

References

Details

Attachments

(1 file)

Places "child" menupopups (sub folders of the BM toolbar/menu) list the nodes starting from a result-node set by their parent menu. This breaks rootNodeIsSelected's assumption that the result's root node for a view is also the root node for that view.
Attached patch patchSplinter Review
Attachment #250989 - Flags: review?(sspitzer)
Comment on attachment 250989 [details] [diff] [review]
patch

r=sspitzer
Attachment #250989 - Flags: review?(sspitzer) → review+
mozilla/browser/components/places/content/controller.js 1.114
mozilla/browser/components/places/content/menu.xml 1.64
mozilla/browser/components/places/content/toolbar.xml 1.69
mozilla/browser/components/places/content/tree.xml 1.49
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: