332499 - Misplaced listbox for floated <select>

Status: RESOLVED FIXED

(Core :: Layout: Floats, defect)

Description

[u60234]

Mozilla/5.0 (Windows; U; Windows NT 5.1; sv-SE; rv:1.9a1) Gecko/20060401 Firefox/1.6a1

The dropdown menu for a floated <select> opens in the wrong position. This happens with both cairo and non-cairo builds.

Steps to reproduce:
1. Open the attached testcase.
2. Click on the select box.

Actual result:
The dropdown menu opens to the left.

This regressed between builds 2006-03-26-07 and 2006-03-27-05.
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-03-26+06%3A00%3A00&maxdate=2006-03-27+05%3A00%3A00&cvsroot=%2Fcvsroot

Comment 1

[u60234]

Attachment: testcase

Comment 2

[Martijn Wargers (dead)]

Backing out the patch for bug 328946 doesn't help, so I guess this has to be a regression from bug 330934.

Comment 3

[Marc Liddell]

Attachment: Fixes floating box

This patch fixes the problem. I don't even know why I changed this in the patch for bug 330934.

Comment 4

[Martijn Wargers (dead)]

Marc, you don't have cvs rights yet?
Do you want me to check this in?

Comment 5

[Marc Liddell]

Yes please.

Comment 6

[Martijn Wargers (dead)]

Checking in layout/base/nsCSSFrameConstructor.cpp;
/cvsroot/mozilla/layout/base/nsCSSFrameConstructor.cpp,v  <--  nsCSSFrameConstru
ctor.cpp
new revision: 1.1216; previous revision: 1.1215
done

Comment 7

[Peter van der Woude [:Peter6]]

did this cause Bug 333590 ?

Comment 8

[Marc Liddell]

It shouldn't have since this is how the code was before bug 330934. But also I have a build with this change in it from yesterday which doesn't have bug 333590.