Closed
Bug 332522
Opened 19 years ago
Closed 19 years ago
Remove $::prodmaxvotes
Categories
(Bugzilla :: Bugzilla-General, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
Attachments
(1 file)
9.64 KB,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
.
Assignee | ||
Comment 1•19 years ago
|
||
Sooner or later, having $bug->product() would be useful. But that's another bug.
Attachment #217795 -
Flags: review?(mkanat)
Comment 2•19 years ago
|
||
Comment on attachment 217795 [details] [diff] [review] patch, v1 This clearly would work *way* more cleanly with $bug->product, and you already do $self->{prod_obj} = new Bugzilla::Product inside of one method, so what's the problem with just adding $bug->product?
Attachment #217795 -
Flags: review?(mkanat) → review-
Assignee | ||
Comment 3•19 years ago
|
||
Comment on attachment 217795 [details] [diff] [review] patch, v1 The reason I added this comment about $bug->product is that several methods in Bug.pm create a product object based on bugs.product_id. Implementing this method would clearly make the code cleaner, but that's definitely another bug as we would have to fix other Bugzilla::Bug methods too. Let's do it in a separate bug.
Attachment #217795 -
Flags: review- → review?(mkanat)
Comment 4•19 years ago
|
||
Comment on attachment 217795 [details] [diff] [review] patch, v1 Great! Looks fine. Tested it, and it works. There's some very minor bitrot in votes.cgi, but it's really easy to fix.
Attachment #217795 -
Flags: review?(mkanat) → review+
Updated•19 years ago
|
Status: NEW → ASSIGNED
Flags: approval?
Updated•19 years ago
|
Flags: approval? → approval+
Assignee | ||
Comment 5•19 years ago
|
||
Checking in globals.pl; /cvsroot/mozilla/webtools/bugzilla/globals.pl,v <-- globals.pl new revision: 1.366; previous revision: 1.365 done Checking in votes.cgi; /cvsroot/mozilla/webtools/bugzilla/votes.cgi,v <-- votes.cgi new revision: 1.38; previous revision: 1.37 done Checking in Bugzilla/Bug.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v <-- Bug.pm new revision: 1.118; previous revision: 1.117 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•