332595 - Changing calendar in Edit Event dialog has no effect

Status: VERIFIED FIXED

(Calendar :: Internal Components, defect)

Description

[Stefan Sitter [:ssitter]]

Changing calendar in Edit Event dialog has no effect

Steps to Reproduce:
1. Create two local calendars, e.g. calendar A and B
2. Create an event in calendar A
3. Open Edit Event dialog and change calendar to B and press OK

Actual Results:
Event still belongs to calendar A

Expected Results:
Event should belong to calendar B

Works in sunbird-0.3a1+.en-US.win32-2006-03-31-07-trunk
Fails in sunbird-0.3a1+.en-US.win32-2006-04-01-08-trunk

Comment 1

[Joey Minta]

Whose responsibility is it to set the .calendar attribute of an item?  The calendar itself when addItem is called, or the event-dialog when calling saveDialog?  The problem is that the transaction's this.mItem.calendar and this.mCalendar don't match.

Comment 2

[Joey Minta]

Attachment: like so

The previous comment, while still perhaps a reasonable question to be answered, is irrelevant to the current bug.  Really, we just need to use the passed in calendar attribute, instead of working off the item.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 217052 [details] [diff] [review]
like so

r=mvl

Comment 4

[Joey Minta]

Patch checked in.

Comment 5

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060929 Sunbird/0.3

Comment 6

[Damian Szczepanik]

Litmus testcase 2475 created

Comment 7

[Damian Szczepanik]

Litmus testcase 2615 created