Closed Bug 332717 Opened 18 years ago Closed 18 years ago

Window menu doesn't work on OSX

Categories

(Calendar :: Sunbird Only, defect)

Product:
Calendar
Component:
Sunbird Only
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mattwillis, Assigned: mattwillis)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file, 5 obsolete files)

rev4 - with bsmedberg's comments applied and whitespace changes shown
3.51 KB, patch
benjamin
: second-review+
benjamin
: approval-branch-1.8.1+
Details | Diff | Splinter Review 
WARNING: unable to load datasource 'rdf:window-mediator': file nsXULTemplateBuilder.cpp, line 1082

windowds isn't being included when we build /mozilla/xpfe/components with MOZ_SUNBIRD=1
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #217184 -
        Flags: first-review?

        Attachment #217184 -
        Flags: second-review?(benjamin)

        Attachment #217184 -
        Flags: first-review?(dmose)

        Attachment #217184 -
        Flags: first-review?

    
    

    
  
Comment on attachment 217184 [details] [diff] [review]
patch

I think we'll do better to ditch the MOZ_SUNBIRD ifdefs entirely.  This should cause Sunbird builds to catch all three of these added components because it'll be building with !MOZ_BROWSER.

        Attachment #217184 -
        Flags: first-review?(dmose) → first-review-

    
  

        Attachment #217184 -
        Flags: second-review?(benjamin)

    
    

    
  


  

        Attachment #217184 -
        Attachment is obsolete: true

        Attachment #217218 -
        Flags: first-review?

    
    

    
  


  

        Attachment #217218 -
        Attachment is obsolete: true

        Attachment #217219 -
        Flags: first-review?

        Attachment #217218 -
        Flags: first-review?

    
  

        Attachment #217219 -
        Flags: first-review? → first-review?(dmose)

    
    

    
  
Comment on attachment 217219 [details] [diff] [review]
rev2 - make sunbird use xulrunner defs

r=dmose, with any appropriate tab/space cleanups on lines that you've changed.  Nice work; this file will be much more readable!

        Attachment #217219 -
        Flags: first-review?(dmose) → first-review+

    
  

        Attachment #217219 -
        Flags: second-review?(benjamin)

        Attachment #217219 -
        Flags: approval-branch-1.8.1?(benjamin)

    
    

    
  


  
Assignee: mvl → mattwillis
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 217219 [details] [diff] [review]
rev2 - make sunbird use xulrunner defs

Isn't winhooks linked into xpfe/components/build (build2)? I think that the build/build2 directories need to be listed last in all cases, for sanity's sake if nothing else.

I'd like to see this patch again with that change and the whitespace fixed.

        Attachment #217219 -
        Flags: second-review?(benjamin)

        Attachment #217219 -
        Flags: second-review-

        Attachment #217219 -
        Flags: approval-branch-1.8.1?(benjamin)

    
    

    
  


  

        Attachment #217219 -
        Attachment is obsolete: true

        Attachment #217525 -
        Attachment is obsolete: true

        Attachment #217845 -
        Flags: second-review?

        Attachment #217845 -
        Flags: approval-branch-1.8.1?

    
    

    
  


  

        Attachment #217845 -
        Attachment is obsolete: true

        Attachment #217846 -
        Flags: second-review?(benjamin)

        Attachment #217846 -
        Flags: approval-branch-1.8.1?(benjamin)

        Attachment #217845 -
        Flags: second-review?

        Attachment #217845 -
        Flags: approval-branch-1.8.1?

    
    

    
  
Comment on attachment 217846 [details] [diff] [review]
rev4 - with bsmedberg's comments applied and whitespace changes shown

Oh, I didn't realize you were re-indenting everything. Ugh.

There have been some changes between trunk and branch, this may need some significant merging.

        Attachment #217846 -
        Flags: second-review?(benjamin)

        Attachment #217846 -
        Flags: second-review+

        Attachment #217846 -
        Flags: approval-branch-1.8.1?(benjamin)

        Attachment #217846 -
        Flags: approval-branch-1.8.1+

    
    

    
  
Why was this checked in on the 1.8.0 branch?

    
  
Blocks: 267789

    
    

    
  
(In reply to comment #11)
> Why was this checked in on the 1.8.0 branch?

'cause I'm a moron.  Backed out (as I mentioned on IRC)

    
    

    
  
Checked in on (correct) 1.8 branch this time.
Keywords: fixed1.8.1

    
    

    
  
checked in, tested, and tinderbox fires put out on branch and trunk.

-> fixed
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  
Verified in 0.3a2
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: