267789 - Sunbird: Provide Dom Inspector and Javascript Debugger (venkman) extensions

Status: RESOLVED FIXED

(Calendar :: General, enhancement)

Description

[Richard Klein]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041018 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041018 Firefox/1.0

It would be nice if dom inspector and venkman were available with sunbird to
help with development.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Simon Paquet [:sipaq]]

Yeah, especially the DOM Inspector would be quite handy.
Richard, can you look into the Firefox code and find out what they are doing to
get it into their default build.

Comment 2

[Richard Klein]

I don't know much about the build process, but looking at the mozconfig file for
firefox it looks like: 

ac_add_options --enable-extensions=inspector

would build inspector.

Comment 3

[Ben Ward]

Is there any chance of DOMi making it into an imminent nightly build? I've been
trying to hack around with the look+feel and Sunbird but working Firefox's DOMi
on the Calendar extension and then editing Sunbird's UserContent.css isn't
offering up the desired results. A more direct interface (Sunbird DOMi) would
maybe help the process.

I'm quite keen to contribute to the UI if I manage anything of substance, but
it's just quite hard to do right now.

Cheers,

Ben

Comment 4

[Gary van der Merwe]

Attachment: Venkman Patch 0.1

Comment 5

[Matthew (lilmatt) Willis]

I'd suggest limiting Sunbird version support from 0.3 to 0.3, since 0.3 is where we fixed the window mediator stuff :)

Comment 6

[Gary van der Merwe]

Attachment: Venkman Patch 0.2

Comment 7

[Gary van der Merwe]

What's changed between patches:
* Increased Min-version number according to lilmatt. (dose not work in 0.2 because you cannot get to extension window)
* Added toolbar button (code stolen from Attachment 205510 [details] [diff])

Comment 8

[Gary van der Merwe]

Attachment: Venkman Patch 0.3

Need to also --enable-jsd

Comment 9

[Gary van der Merwe]

BTW - I'm stuck with Inspector - and am not working on it. (Maybe we should open a new bug for Inspector).

Comment 10

[Matthew (lilmatt) Willis]

Attachment: For DOMi - Adds support for Sunbird

Comment 11

[James Ross]

Comment on attachment 218331 [details] [diff] [review]
Venkman Patch 0.3

>+<!-- Sunbird toolbar button -->
>+<toolbarpalette id="calendarToolbarPalette">
>+   <toolbarbutton id="tb-venkman-open" oncommand="start_venkman()" 

Please fix this <toolbarbutton> to use a unique ID within the overlay.


>+		<!-- target: Mozilla Sunbird version 0.3 -->
>+		<em:targetApplication>
>+			<Description>
>+				<em:id>{718e30fb-e89b-41dd-9da7-e25a45638b28}</em:id>
>+				<em:minVersion>0.3a</em:minVersion>

I don't think the 'a' is needed there, is it?

r=silver with those nits fixed

Comment 12

[Gary van der Merwe]

Attachment: Venkman Patch 0.4

> don't think the 'a' is needed there, is it?

If I just make it 0.3 - It does not install in 0.3a1 or 0.3a2, which are the only release's availible.

r=Silver

dmose: Please will you check this in for me?

Comment 13

[Gary van der Merwe]

Attachment: Venkman Patch 0.5

Fixed some small things in that patch, like the path to sunbird mozconfig was wrong, and added my name to lic blocks.

r=silver

Comment 14

[Matthew (lilmatt) Willis]

Comment on attachment 221068 [details] [diff] [review]
Venkman Patch 0.5

+ac_add_options --enable-jsd

This line is unnecessary as we'll pick up jsd from 
http://lxr.mozilla.org/seamonkey/source/configure.in#4320

This is why we had --disable-jsd in the first place

Comment 15

[timeless]

Comment on attachment 218849 [details] [diff] [review]
For DOMi - Adds support for Sunbird

grumble, so much for reusable code

Comment 16

[Matthew (lilmatt) Willis]

Adding whiteboard to be landed post-0.3a2

Comment 17

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This may have caused balsa to go orange. Since matt wasn't around, I backed it out.

Comment 18

[Matthew (lilmatt) Willis]

Committed DOMi piece on trunk and MOZILLA_1_8_BRANCH

Comment 19

[Matthew (lilmatt) Willis]

Venkman patch 5 with my nit checked in to trunk
This patch needs more work for branch. Leaving open for that.

Comment 20

[Joey Minta]

(In reply to comment #18)
> Committed DOMi piece on trunk and MOZILLA_1_8_BRANCH
> 
Backed out of both due to balsa orange.  (I left the sunbird mozconfig change in though)

Comment 21

[Matthew (lilmatt) Willis]

Ok, all existing patches are checked in on trunk and MOZILLA_1_8_BRANCH.

Venkman patch will not work on branch. Needs further work.

Comment 22

[Matthew (lilmatt) Willis]

(In reply to comment #21)
> Ok, all existing patches are checked in on trunk and MOZILLA_1_8_BRANCH.
> Venkman patch will not work on branch. Needs further work.

First off, nice contradiction I made there.
Next, since we're not releasing Sunbird from branch at the moment, and Venkman is available for branch Thunderbird (for use with Lightning), I'm going to close this bug.  If and when we get Sunbird on branch, then we can open a new bug to fix Venkman, if it still needs fixing.

-> FIXED