Closed Bug 332826 Opened 19 years ago Closed 19 years ago

Fix comment sorting, persistence of sort

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect)

Product:
addons.mozilla.org Graveyard
Component:
Public Pages
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: bugzilla-mozilla-20000923, Assigned: morgamic)

References

(
URL
)

Details

(Keywords: regression)

Attachments

(1 file)

Patch for fixing sorting (committed, it's pretty straightforward).
6.46 KB, patch
Details | Diff | Splinter Review
https://addons.mozilla.org/firefox/16/comments/ The comments are in a completely random order; instead, they should be sorted by date (within the "helpfulness" rating).
Should be sorted by most recent
(In reply to comment #1) > Should be sorted by most recent Why?
Per my original comment, they should be sorted most recent /within the same helpfulness group/, i.e. sort by helpfulness first and then date as a secondary sort. This will at least stop completely outdated coments appearing as if they are new.
James: I agree with you, but I'm not sure if Kurt wants to do away with helpfullness and just use date.
Kurt, if you do want to do away with helpfulness, that is a seperate bug.
Should definently be sorted by helpfulness but be sorted by most recent also. Because old comments refer to older versions which if you got a bad comment for that version not working and you have since updated that comment from a year ago wouldnt appear first. Changing summary to refelect this.
Summary: Comments are unsorted beyond "helpfulness" → Comments should be sorted by newest and helpfulness
Sorting by anything other than newest on the description page is very confusing. - developer replies are out of context (actually they are completely missing now WTF?) - comments refering to features/bugs in previous versions should not appear before relevent (more recent) comments A
(In reply to comment #7) > Sorting by anything other than newest on the description page is very > confusing. > > - developer replies are out of context (actually they are completely missing > now WTF?) Developers can use the developer's comments section. Remember that the comments are not designed to be for support.
(In reply to comment #8) > Developers can use the developer's comments section. > > Remember that the comments are not designed to be for support. > Then what is the "add a comment without ranking" button for? The comment at the top of one of my extensions is "Great extension, would be better if it did X". I added a reply (4 months ago) explaining that it did this already. Using the developers comments to explain/rebut outdated comments that appear on the description page is not a workable solution. A better solution for me at this point is to add a "comment system is completely hosed, please ignore" comment, which I've done, but I don't really like it as a long term solutions. Like it or not people ask quesions and give suggestions in the comments. Unless you associate them with a release, showing them out of order severly reduces their value.
Yes, please sort by date by default. I'm sure the change was well-intentioned, but it's just awful.
Okay -- thanks for the comments guys. Would a defaut sort of most helpful but sorted by date after that help? The reason for the most helpful sort was so users get the most useful comments first. I think this is relatively important... what do you think? Would adding the date sort after the most helpful be a proper compromise? Also, sorry for the headache -- we will get this fixed up right w/ your help and feedback. :) You're right, I didn't mess it up on purpose... :)
Status: NEW → ASSIGNED
(In reply to comment #11) > Okay -- thanks for the comments guys. Would a defaut sort of most helpful but > sorted by date after that help? Not really. > > The reason for the most helpful sort was so users get the most useful comments > first. I think this is relatively important... what do you think? No. "there is a big bug in this release, install the previous one" is a very helpful comment. But there's no way it should stay at the top of the list forever. I don't think the concept of helpfulness is appropriate at all. It's great for book reviews, because the contents of the book remain static. Extensions don't. Being able to sort by lowest/highest rank is kind of handy, but we really need some annotation against the comment showing the release number or this can be completely misleading.
Gradual helpfulness decrease over time is what I'd suggest, but that just sounds hard :s
Okay, so I'll change the default sort to newest, which will be sorted by date then helpfulness. Then if people want to see helpful comments (as rated by other users) they can use the sort. Thanks for the comments.
(In reply to comment #14) > Okay, so I'll change the default sort to newest, which will be sorted by date > then helpfulness. Then if people want to see helpful comments (as rated by > other users) they can use the sort. > Sounds good. Though I'd still like to see my replies in the list... You know that sort doesn't work now. Right? I change the sort type, but when I go to the next page it reverts back to the default.
(In reply to comment #15) > You know that sort doesn't work now. Right? > > I change the sort type, but when I go to the next page it reverts back to the > default. See Bug 333108
"I don't think the concept of helpfulness is appropriate at all. It's great for book reviews, because the contents of the book remain static. Extensions don't." I absolutely agree. If you are keeping this functionality, please at least consider tagging each comment with an associated extension version number.
Summary: Comments should be sorted by newest and helpfulness → Fix comment sorting, persistence of sort
*** Bug 333108 has been marked as a duplicate of this bug. ***
Getting this fixed before too many people riot. Verify in about an hour. Thanks.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
There's something odd going on; the comments page is only /sometimes/ remembering the sort order in the Prev/Next links, and - more importantly - it is still defaulting to "Most helpful" first.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
It seems that the pages that are correct also show the extension's rating at the top, and the broken pages don't. I can only think the cache is being silly...
I think this is probably attributed to a node not being restarted. I'll try to figure this out w/ the sysadmins. Thanks.
Status: REOPENED → ASSIGNED
Okay -- inconsistencies fixed. APC requires a graceful restart for apache -- and that wasn't done last night. Check now -- thanks. :)
Status: ASSIGNED → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
Looks good. :)
Status: RESOLVED → VERIFIED
Organising bugs. Sorry for the bugspam.
Version: unspecified → 2.0
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: