33305 - Quoted text in a much smaller font than normal text

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect, P3)

Description

[Ben Bucksch (:BenB)]

From bug #31047:

------- Additional Comments From [e-mail] 2000-03-22 17:11 -------
Rich says he checked in his fix on 3/14, but in the 3/22 build I'm still seeing
quoted text in a much smaller font than unquoted text, and changing the pref for
font size for quoted text has no effect.  Reopening.

------- Additional Comments From [e-mail] 2000-03-22 17:18 -------
Correct, the place where I'm seeing this is on the tip, not the beta branch.

------- Additional Comments From [e-mail] 2000-03-23 11:05 -------
Requesting beta2 consideration, because the current fixed size is too small to
read easily.  If it were the same size as the quoted text, I wouldn't mind so
much not being able to change it. 

------- Additional Comments From [e-mail] 2000-03-23 11:18 -------
akk, however PDT might rate it, I'll take at look at it for M16 with bug #31906.

------- Additional Comments From [e-mail] 2000-03-25 07:37 -------
akk, worksforme. Can you please describe detailed, what you're seeing for which
msgs and what your prefs are for quoting style, mail font family (variable or
fixed width) and x-unicode fonts?

------- Additional Comments From [e-mail] 2000-03-25 08:23 -------
Rich, do you mind, if I take this bug (i.e. the bug akk mentioned)?

------- Additional Comments From [e-mail] 2000-03-25 08:27 -------
Sure...go for it. Keep in mind, now that a beta1 is just about out the door...I 
am very very very scared of major rewrites in libmime.

Comment 1

[Ben Bucksch (:BenB)]

Taking beta2 over from 31047.

Comment 2

[Akkana Peck]

With the 3/27 build, it's gotten even weirder.  Now, in a plaintext message,
quoted text is always in the same font style and size as the rest of the
message, but sometimes that is the normal plaintext font, and sometimes it's the
tiny italic font that in earlier builds were always applied to the quoted text
only.

I'll attach a screenshot of a sample message where both quoted text and unquoted
text is shown in the too-small italic font.  This is just a plaintext message,
according to 4.7.  The font in the "Alec Flett wrote" attribution is my normal
plaintext font; I expected to see the unquoted text in that font, and the quoted
text in italic because that's what my pref says to do.

Comment 3

[Akkana Peck]

Attachment: Screenshot of a message that's displayed wrong

Comment 4

[Ben Bucksch (:BenB)]

Akk, can you tell the prefs I mentioned above, too? tbx.



BTW: I can't say, when I'll get to this bug, but I hope before beta2.

Comment 5

[Akkana Peck]

I have:
user_pref("font.name.monospace.x-unicode", "clean");
user_pref("font.size.fixed.x-unicode", 14);

I don't see any other prefs that look like they're the ones you asked for, so at
this point I guess I'm using the defaults.  When I bring up the prefs pane, it
says I should be seeing italic, same size, black. I've tried to change the color
to something else, but the pref doesn't stick.  I've changed the font to other
sizes, and I think it does change my pref, but it does not change what I see in
the message pane.

Comment 6

[Ben Bucksch (:BenB)]

akk, what does the pref window say, which font family (variable or fixed width)
you use for plain text msgs? (should be somewhere in the mailnews pref panes.)

Does this disturb you mailnews usage? If you want, I can attach my (not fully
tested) fix for bug #31906 to that bug - maybe it helps (but i have no idea, if
it
will).

Comment 7

[Akkana Peck]

I use fixed width font to show plaintext.

It does disturb my mail usage, because quoted text -- and now, sometimes, even
unquoted text) is too small for me to read.

Comment 8

[lchiang]

bulk move to M16.  

Comment 9

[Akkana Peck]

Adding more keywords since this is one of the regressions which has made me stop
using mozilla for daily mail.

Comment 10

[Ben Bucksch (:BenB)]

akk, set Preferences|MailNews|Quoted plain text appearance|Style to Regular. If
that doesn't help, try to reset (delete) your Unicode font prefs. Tell me, if
that helped.

Comment 11

[Akkana Peck]

Yes, setting the font pref to regular helped.  Both regular and bold are the

same size as the normal plaintext message text; it's just the italic that's so

much smaller.



Thanks for the workaround!  Guess it's not dogfood any more.

Comment 12

[Ben Bucksch (:BenB)]

Akk, you said, you saw this in normal text as well? Can you give a reproduction?

If this appears only for quoted text with style = italic, I think, it's just an
inferior font (clean italic).

Comment 13

[Akkana Peck]

This happens when viewing *plaintext* messages, with plaintext quotations, in
the message pane.  It happens every time, on every plaintext message which has
quoted material.

Comment 14

[pmock]

Changing qa assigned to [e-mail]

Comment 15

[leger]

Can PDT get info on how this is looking with that latest builds please?  Is it 
still so small you cannot read?

Comment 16

[Christopher Blizzard (:blizzard)]

It's annoying.  You can't tell how text lines up in the plain text editor.  I
can't tell how many newlines there are between quoted text and my comments. 
Output from the text editor looks aweful ( might be unrelated to this. ) It's
one of the two things that keeps me from using Mozilla Mail/News.

Comment 17

[Ben Bucksch (:BenB)]

blizzard, did you try to set Preferences|MailNews|Quoted plain text
appearance|Style to Regular?

Comment 18

[Akkana Peck]

I'm still (or again) seeing this: quoted text is in italic and is much smaller
than the normal font, even though my pref says to use the same size for quoted
text.

Comment 19

[Ben Bucksch (:BenB)]

Akk or blizzard, please get the latest patch for bug 31906 (the large one with
the mime diffs) <http://bugzilla.mozilla.org/showattachment.cgi?attach_id=8737>
and retest. If the bug is fixed, mark it so. If not, move to M17 and find a way
to reproduce, please.

Reproduction quest notes:
I guess, this is due to differences in font installations (in OS) or font
settings (in Mozilla). This will be hard to track down. I don't want to
uninstall/reinstall font servers, font libraries and fonts trying to reproduce
this bug.
- Try to set your fonts for Western and Unicode to Times/Helvetica/Courier.
- If this gives no clue, pass the buck to QA and let it try to find a reliable
reproduction way, that my system outlives.

Comment 20

[leger]

pmock, can you retest with latest build and attach sceenshot?  We need to see 
this.

Comment 21

[Akkana Peck]

For me, in today's build with my nonstandard font prefs, it's actually looking
much better.  And the quote color pref works now!  I'll be interested to hear if
it works with standard prefs as well.

Comment 22

[pmock]

On Win32 commercial seamonkey build 2000-060209-m16 installed on Win98, the 
quoted text using the view message option for italic, regular, bold italic, and 
bold looks all right.  In my prefs.js file, I do not have any font user pref 
setting. As Akkana noted, the color setting is working too.

Next, I will test on Linux and Mac.  

Comment 23

[pmock]

On Linux commercial seamonkey build 2000-060208-m16 installed under Linux Red 
Hat 6.1, the quoted text using the view message option for italic, regular, bold 
italic, and bold looks all right, same size.  In my prefs.js file, I do not have 
any font user pref setting. As Akkana noted, the color setting is working too.

Next, I will test on Mac.  

* I did notice these behaviors with this feature:
  1) The font size menu for (smaller, Regular, bigger) doesn't appear to be 
working.
  2) Any text typed below the quoted text uses the attribute of the quoted text. 
 If my quoted text is italic and set to color blue, the replied text is italic 
and blue.
  3) When I am in the reply composition window editing the text, the text I type 
appears bigger than the quoted text.

Comment 24

[Akkana Peck]

#1 sounds like part of this bug (I remember seeing that before).
#2 I was also seeing yesterday. Should that also be part of this bug, or a
separate one?
#3 has a separate bug filed on it already, and has been annoying a lot of
people.  Unfortunately, I can't seem to find the bug number ...

Comment 25

[Christopher Blizzard (:blizzard)]

Yeah, #2 is definitely broken for me out of the box.

Comment 26

[Ben Bucksch (:BenB)]

Did anybody try my patch?

Comment 27

[pmock]

On Mac commercial seamonkey build 2000-060208-m16, I see similar behavior as 
win32 and linux.  Mac has outstanding bug 40204 which means I could not test 
color. 

I think bug #2 should be part of this bug since it has to do with font size. 

Comment 28

[Ben Bucksch (:BenB)]

Clarifying Status whiteboard. I do not see this problem with my patch for bug
31906 and my system. Please see my comment from 2000-05-16 17:51.

Comment 29

[Peter Trudelle]

[nsbeta2-]

Comment 30

[Christopher Blizzard (:blizzard)]

No, I haven't.  That patch is tremendous.  Is all that required to fix this?

Comment 31

[Ben Bucksch (:BenB)]

blizzard, it is an overhaul of the relevant classes. Especially what I suspect
as the reason for #2 (buggy html container output) has been completely
rewritten.
Why should I bother fixing code, that will be obsolete in a few days anyway?

Comment 32

[Christopher Blizzard (:blizzard)]

Have you gotten anyone to review the code?

Comment 33

[Ben Bucksch (:BenB)]

The code for bug 31906 is checked in. Unfortunately, another bug messes it up,
see my post "Bug 41637 - Double qoute tags" on .mailnews
<news://news.mozilla.org/[e-mail]> for a workaround.

Please test it again (using a current build and the workaround mentioned).
Thanks.

Comment 34

[Christopher Blizzard (:blizzard)]

The news server responds "no such article."

Comment 35

[Ben Bucksch (:BenB)]

Try <news://news.mozilla.org/[e-mail]>. If this also fails,
just go to the newsgroup. It's a recent post.

Comment 36

[Ben Bucksch (:BenB)]

Resolving as FIXED. I guess, this has been fixed with bug 31906. I can't
reproduce it, and noone yet tested it, so I'll let it up to QA to verify or
reopen.

Comment 37

[Christopher Blizzard (:blizzard)]

This is not fixed.  I just started using the plain text editor again and it's
still got the most screwed up fonts.

Comment 38

[Christopher Blizzard (:blizzard)]

oops, wrong bug. *blush*

Comment 39

[pmock]

Verified as fixed on linux using the following build:
 linux commercial seamonkey build 2001-010410-mtrunk installed on P200 RedHat 
6.2

I wasn't able to reproduce the problem.