333074 - In <mailWindowOverlay.js>, 1+1 error when opening a specific attached .eml file

Status: NEW

(MailNews Core :: Attachments, defect)

Description

[Serge Gautherie (:sgautherie)]

With one of the emails I received recently,
when opening its attached .eml file,
I get an JS.C. error on SM v1.1a and v1.0.1 branches,
which I don't get on Trunk.

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20060403 SeaMonkey/1.5a] (nightly) (W98SE)

No bug.

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20060406 SeaMonkey/1.1a] (nightly) (W98SE)

{{
Error: msgId has no properties
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 2342
}}

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.0.2) Gecko/20060406 SeaMonkey/1.0.1] (nightly) (W98SE)

{{
Error: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMessenger.msgHdrFromURI]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrome://messenger/content/mailWindowOverlay.js :: HandleMDNResponse :: line 2329"  data: no]
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 2329
}}

(From a LXR search/lookup)
Would the latter error be fixed by porting bug 204350 to the Gv1.8.0 branch ?

Would there be another patch to port from Trunk to branches to fix the former error ?

Comment 1

[Serge Gautherie (:sgautherie)]

My mistake: SMv1.5a/Trunk has the |msgId| error too.

[Mozilla Thunderbird, version 3 alpha 1 (20060403)] (nightly) (W98SE)

And TB Trunk too !

Comment 2

[Mike Cowperthwaite]

TB2a1-0328, TB 3a1-0329, Win2K:  I don't see the second error, just the 'msgId has no properties' error, when opening a .EML without a Message-Id header.  Maybe there's something specific about the .EML attachment you're using to 
cause the second error?  Or possibly something specific to Win98?

Unrelated, but xref bug 324954.

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> TB2a1-0328, TB 3a1-0329, Win2K:  I don't see the second error, just the 'msgId

Exactly, the second error is from the Gv1.8.0 branch: you should test with TBv1.0.x to get it.
It happens before the first error can happen: see the line numbers.

Comment 4

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a3) Gecko/20060628 SeaMonkey/1.1a] (nightly) (W98SE)

Error still present in 1.8.1 branch.
[
Error: msgId has no properties
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 2364
]

Comment 5

[Martin Mokrejs]

Still in trunk. I hit this as well on Linux here:

++WEBSHELL 0x98839f0 == 12
++DOMWINDOW == 25
++DOMWINDOW == 26
++DOMWINDOW == 27
WARNING: nsMsgProtocol::SetContentCharset() not implemented: file nsMsgProtocol.cpp, line 629
Considering text/plain alternative
WARNING: nsMsgProtocol::SetContentCharset() not implemented: file nsMsgProtocol.cpp, line 629
Ignoring text/html alternative
WARNING: nsMsgProtocol::SetContentCharset() not implemented: file nsMsgProtocol.cpp, line 629
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file nsMsgDBView.cpp, line 5706
WARNING: recurring into frame construction: 'mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0', file ../../dist/include/layout/nsPresContext.h, line 858
WARNING: recurring into frame construction: 'mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0', file ../../dist/include/layout/nsPresContext.h, line 858
WARNING: recurring into frame construction: 'mPresContext->mLayoutPhaseCount[eLayoutPhase_FrameC] == 0', file ../../dist/include/layout/nsPresContext.h, line 858
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file nsMsgDBView.cpp, line 5706
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "msgId has no properties" {file: "chrome://messenger/content/mailWindowOverlay.js" line: 2434}]' when calling method: [nsIMsgHeaderSink::onEndMsgHeaders]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "<unknown>"  data: yes]
************************************************************
mailCharsetLoadListener: windows-1251 
--DOMWINDOW == 26
--WEBSHELL 0x976d0e0 == 11
--WEBSHELL 0x960ebe8 == 10
--WEBSHELL 0x9464de0 == 9
--DOMWINDOW == 25
--DOMWINDOW == 24
--DOMWINDOW == 23
--DOMWINDOW == 22
--DOMWINDOW == 21
--DOMWINDOW == 20

Comment 6

[Jim Porter (:squib)]

Does this still happen? Is there a testcase I could try?