Camino 1.0 Steps to reproduce: 1. Open a new window 2. Ctrl-click the toolbar, and choose "Text only" for the buttons. You'll notice that Back/Forward are clickable and enabled in the toolbar, even if you have not used this window before. This does not happen in the toolbar button as images-mode.
See also bug 316835, which tracks improperly disabled buttons as buttons.
Target Milestone: --- → Camino1.1
No longer blocks: 316835
I'll look into this.
Assignee: mikepinkerton → bugzilla
Whiteboard: [good first bug]
Why NSToolbarItem doesn't do this by default in the custom view case is beyond me.
Assignee: bugzilla → stuart.morgan
Status: NEW → ASSIGNED
Attachment #242998 - Flags: review?
Comment on attachment 242998 [details] [diff] [review] fix +// Make sure that them menu form, which is used for the text-only view, r=me with the comment cleaned up
Attachment #242998 - Flags: review? → review+
With gooder English
(In reply to comment #3) > Created an attachment (id=242998)  > fix > > Why NSToolbarItem doesn't do this by default in the custom view case is beyond > me. File an apple bug?
The docs mention that enabling of the menu item rep is separate for custom-view items, so they already know. I just don't know why they think it's desirable.
Comment on attachment 243000 [details] [diff] [review] fixed fix sr=pink
Attachment #243000 - Flags: superreview?(mikepinkerton) → superreview+
Whiteboard: [good first bug] → [good first bug][needs checkin]
Checked in on 1.8branch and trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][needs checkin] → [good first bug]
You need to log in before you can comment on or make changes to this bug.