333222 - Buttons not disabled when they should, if toolbar buttons are text-only

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Håkan Waara]

Camino 1.0

Steps to reproduce:

1. Open a new window
2. Ctrl-click the toolbar, and choose "Text only" for the buttons.

You'll notice that Back/Forward are clickable and enabled in the toolbar, even if you have not used this window before. This does not happen in the toolbar button as images-mode.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

See also bug 316835, which tracks improperly disabled buttons as buttons.

Comment 2

[Chris Lawson (gone)]

I'll look into this.

Comment 3

[Stuart Morgan]

Attachment: fix

Why NSToolbarItem doesn't do this by default in the custom view case is beyond me.

Comment 4

[Nick Kreeger]

Comment on attachment 242998 [details] [diff] [review]
fix

+// Make sure that them menu form, which is used for the text-only view,

r=me with the comment cleaned up

Comment 5

[Stuart Morgan]

Attachment: fixed fix

With gooder English

Comment 6

[Håkan Waara]

(In reply to comment #3)
> Created an attachment (id=242998) [edit]
> fix
> 
> Why NSToolbarItem doesn't do this by default in the custom view case is beyond
> me.

File an apple bug?

Comment 7

[Stuart Morgan]

The docs mention that enabling of the menu item rep is separate for custom-view items, so they already know. I just don't know why they think it's desirable.

Comment 8

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 243000 [details] [diff] [review]
fixed fix

sr=pink

Comment 9

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk.