Steps to reproduce:
1. Open a new window
2. Ctrl-click the toolbar, and choose "Text only" for the buttons.
You'll notice that Back/Forward are clickable and enabled in the toolbar, even if you have not used this window before. This does not happen in the toolbar button as images-mode.
See also bug 316835, which tracks improperly disabled buttons as buttons.
I'll look into this.
Created attachment 242998 [details] [diff] [review]
Why NSToolbarItem doesn't do this by default in the custom view case is beyond me.
Comment on attachment 242998 [details] [diff] [review]
+// Make sure that them menu form, which is used for the text-only view,
r=me with the comment cleaned up
Created attachment 243000 [details] [diff] [review]
With gooder English
(In reply to comment #3)
> Created an attachment (id=242998) 
> Why NSToolbarItem doesn't do this by default in the custom view case is beyond
File an apple bug?
The docs mention that enabling of the menu item rep is separate for custom-view items, so they already know. I just don't know why they think it's desirable.
Comment on attachment 243000 [details] [diff] [review]
Checked in on 1.8branch and trunk.