Closed Bug 333229 Opened 18 years ago Closed 18 years ago

Text-plain signature formatted incorrectly in HTML composition

Categories

(MailNews Core :: Composition, defect)

Product:
MailNews Core
Component:
Composition
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: ain, Assigned: mscott)

References

Details

(Keywords: regression)

Attachments

(2 files)

Text-plain signature on 1 line
35.60 KB, image/png
Details
Subject signature
140 bytes, text/plain
Details 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1

New mail window pops up with invalid signature

Reproducible: Always

Steps to Reproduce:
1. Open mail compose window (Write, Ctrl + N) with a text-plain signature set to appear on a new email

Actual Results:  
Signature appears on 1 line despite the linebreaks

Expected Results:  
Signature should appear as in it's text file
Attached image Text-plain signature on 1 line — 
This illustrates the very same signature on old version (left) and on latest trunk (right). Signature file or regarding preferences have not been changed prior updating.
Version: unspecified → Trunk
User-Agent: Thunderbird 3.0a1 (Windows/20060407)
Please attach your sig file to this bug.

Also, please report your settings for these prefs:
  mailnews.wraplength
  editor.htmlWrapColumn
Summary: Text-plain signature formatted incorrectly → Text-plain signature formatted incorrectly in HTML composition
Attached file Subject signature — 

    
    

    
  
(In reply to comment #3)
> Please attach your sig file to this bug.
> 
> Also, please report your settings for these prefs:
>   mailnews.wraplength
>   editor.htmlWrapColumn
> 

both values are 72


    
    

    
  
Also tested on Thunderbird 3.0a1 (Windows/20060408). No changes

    
    

    
  
It appears to be an autodetection issue as if you check out the "Compose messages in HTML format" and force it to go all text-plain the signature will be handled properly

    
    

    
  
(In reply to comment #7)
> It appears to be an autodetection issue as if you check out the "Compose
> messages in HTML format" and force it to go all text-plain the signature will
> be handled properly

Even if you compose in HTML, a plain-text sig is supposed to maintain the line breaks.  Using the sig you supplied, I get the expected result.  You have some setting which is causing this symptom, and I'd like to understand what it is.

Try this: open an HTML compose window, with the sig displayed as you originally reported.  Focus on the body, Select All (ctl+A), then from the menu
  Insert | HTML  -- the window that pops up will contain the HTML source of the selection.  Please paste that info into a response in this bug.

    
    

    
  
-- Ain Tohvri
Flashbit LLC
Skype: flashbit
Phone: +372 712 0188
Mobile: +372 510 8888
Email: ain@flashbit.net
Website: www.flashbit.net

    
    

    
  
Mike, I'm seeing the same behaviour here. I can also see a bug filed against SeaMonkey MailNews (bug 333338), describing the same behaviour, which suggests this is a core bug.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression

    
  
Component: Message Compose Window → MailNews: Composition
Product: Thunderbird → Core

    
    

    
  
*** Bug 333338 has been marked as a duplicate of this bug. ***

    
    

    
  
Bug also present in recent trunk builds on Mac (version 3 alpha 1 (20060412), PPC, 10.4.6) --> Adjusting OS & Platform accordingly.
OS: Windows XP → All
Hardware: PC → All

    
    

    
  
Assuming comment 9 is in fact what I asked for in comment 8, there's quite a 
bit missing there.  Using the same sig, the correct results should be:
====
<br>
<pre class="moz-signature" cols="72">-- <br>Ain Tohvri<br>Flashbit LLC<br>Skype: flashbit<br>Phone: +372 712 0188<br>Mobile: +372 510 8888<br>Email: ain@flashbit.net<br>Website: www.flashbit.net</pre>
====
(The text within the <pre> is all on one line.)

    
    

    
  
Also present in SeaMonkey 2006041108

    
    

    
  
This appears to be trunk-only; I don't see the symptom in TB 2a1-0416, but it's there in TB 3a1-0412.

    
  
Flags: blocking1.9a1?

    
    

    
  
anyone have a regression window for this?

    
    

    
  
Regression window: Rough estimate: The past week or two.

    
    

    
  
Between April 6 and 9, see bug 333338.

    
    

    
  
This was caused by Bug 332239. I backed that out and the multi line signature files stopped showing up on a single line when I displayed them in the message pane.




Blocks: 332239
Flags: blocking1.9a1? → blocking1.9a1+

    
    

    
  
Is there a difference in the DOM of the signature in a build that shows the problem and a build that does not?

    
    

    
  
Just noting that I'm seeing this bug now too on Seamonkey:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060420 SeaMonkey/1.5a

I think my previous build that didn't have the problem was March 24 but you've already narrowed it down.

    
    

    
  
I got crossed over in the bugs I was backing out. It wasn't 332239. It was Bug 228920. Sorry for the noise.
No longer blocks: 332239

    
    

    
  
Blake, I think Bug 228920 caused this regression with mail signatures. When we paste in the dom fragment for the signature, we seem to be losing our line returns.

Blocks: 228920

    
    

    
  
When there are 2 or more options and it's difficult to decide which one is "the best", make it configurable !

In this case, make configuration (via Mail & News account settings), e.g.:

"attach signature as:"

- plain text
- HTML
- image
- whatever

This is only suggestion, of course

    
    

    
  
I think the patch in bug 333063 fixes this.
Depends on: 333063

    
    

    
  
*** Bug 335211 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 335302 has been marked as a duplicate of this bug. ***

    
    

    
  
Now that the patch in bug 333063 has been checked in, can someone test to see if this bug is fixed as well?

    
    

    
  
I just downloaded Thunderbird (20060425) update and it is not fixed there.

    
    

    
  
(In reply to comment #30)
> I just downloaded Thunderbird (20060425) update and it is not fixed there.
> 

The fix went in after yesterdays build was built.

It's working fine for me with 20060426.

    
    

    
  
(In reply to comment #31)
> (In reply to comment #30)
> > I just downloaded Thunderbird (20060425) update and it is not fixed there.
> > 
> 
> The fix went in after yesterdays build was built.
> 
> It's working fine for me with 20060426.
> 

I concur.  Updated to 20060426 and it seems ok.

    
    

    
  
Per previous reportsand because my own Linux build (cvs as of apr. 26 1700 UTC) also works fine, I mark thisas fixed.   If anyone still has this problem, please report in this thread.  Someone (or I, if I notice) will reopen.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  
Verifying on Windows XP version 3 alpha 1 (20060426)
Status: RESOLVED → VERIFIED

    
    

    
  
*** Bug 335634 has been marked as a duplicate of this bug. ***
Product: Core → MailNews Core

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: