333277 - null description in helper version info leaves Download Actions blank

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Phil Ringnalda (:philor)]

Thunderbird port of bug 308204: Windows helper apps like Azureus that have version info, but have a blank description field in it, cause nsLocalFileWin::getVersionInfoValue to throw, which leaves the whole list blank when it's uncaught. You get the fix for the Change Action dialog from toolkit in bug 308204, but not for the main list.

STR:
1. Install Azureus on Windows.
2. Mail yourself an attached .torrent
3. Tell Thunderbird to always open with Azureus
4. Open Tools > Options > Attachements > View & Edit Options, the list will be blank

Comment 1

[Phil Ringnalda (:philor)]

Attachment: fix

Comment 2

[Scott MacGregor]

Comment on attachment 217712 [details] [diff] [review]
fix

thanks Phil.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

mozilla/mail/components/preferences/downloadactions.js 	1.5

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 217712 [details] [diff] [review]
fix

This simple fix should probably land on the branch for TB2, Mike Cowperthwaite noticed it there.

Comment 5

[Mike Cowperthwaite]

Ping -- this would be really great for TB 2 -- see bug 364594, which is Mac-only but creates a problem that the user can't get out of, without manually editing mimeTypes.rdf, unless this bug is fixed.

Comment 6

[Scott MacGregor]

Weird, this approval request doesn't show up in my bugzilla query for pending tb2 approvals and I'm not cc'ed on the bug so I never saw this. Sorry we didn't get it in tb2. I'm not sure why it is evading my query. Looking at my query, I see I did not select the 'Preferences' component in Thunderbird. That's too bad. Sorry guys. 

We could try to get this in for a point release. 

Comment 7

[Phil Ringnalda (:philor)]

Comment on attachment 217712 [details] [diff] [review]
fix

Gah, this poor thing just keeps getting forgotten.

Should be safe as houses - the same change to the same code in Firefox has been on 1.8 for a few days over a year now.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 217712 [details] [diff] [review]
fix

approved for 1.8.1.5, a=dveditz for release-drivers

Comment 9

[Phil Ringnalda (:philor)]

mail/components/preferences/downloadactions.js 1.1.4.3