Closed
Bug 333287
Opened 18 years ago
Closed 13 years ago
rip out pointless table frame null checks
Categories
(Core :: Layout: Tables, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 716408
People
(Reporter: bernd_mozilla, Assigned: bernd_mozilla)
References
()
Details
Attachments
(1 file)
|
2.46 KB,
patch
|
Details | Diff | Splinter Review |
nsTableColGroupFrame::GetContinuousBCBorderWidth should do the same for table frame and col http://lxr.mozilla.org/seamonkey/source/layout/tables/nsTableColGroupFrame.cpp#548 http://lxr.mozilla.org/seamonkey/source/layout/tables/nsTableColGroupFrame.cpp#549
Attachment #224427 -
Flags: superreview?(bzbarsky)
Attachment #224427 -
Flags: review?(bzbarsky)
|
||
Comment 3•18 years ago
|
||
So why is this null-check needed? When does a rowgroup not have a parent table?
Attachment #224427 -
Flags: superreview?(bzbarsky)
Attachment #224427 -
Flags: review?(bzbarsky)
This is all bogus and comes from my paranoia, we assert inside GetTableFrame, if GetTableFrame does not return a valid table things have gone so far south that a null check will not really help, it will crash anyway rather sooner than later. We could probably rip out some of those pointless null checks.
Summary: table frame null check needed → rip out pointless table frame null checks
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•