Closed
Bug 716408
Opened 11 years ago
Closed 11 years ago
Minor cleanup in table code
Categories
(Core :: Layout: Tables, defect)
Core
Layout: Tables
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
Details
Attachments
(7 files, 1 obsolete file)
6.34 KB,
patch
|
bernd_mozilla
:
review+
|
Details | Diff | Splinter Review |
32.46 KB,
patch
|
bernd_mozilla
:
review+
|
Details | Diff | Splinter Review |
1.02 KB,
patch
|
bernd_mozilla
:
review+
|
Details | Diff | Splinter Review |
894 bytes,
patch
|
bernd_mozilla
:
review+
|
Details | Diff | Splinter Review |
2.21 KB,
patch
|
bernd_mozilla
:
review+
|
Details | Diff | Splinter Review |
1.97 KB,
patch
|
bernd_mozilla
:
review+
|
Details | Diff | Splinter Review |
4.46 KB,
patch
|
bernd_mozilla
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
GetFirstInFlow() can never return null so we can remove these null-checks
Attachment #586835 -
Flags: review?(bernd_mozilla)
Assignee | ||
Comment 2•11 years ago
|
||
The mIsBorderCollapse bit is set on all table frames in Init so there's no need to get this bit from the first-in-flow frame.
Attachment #586836 -
Flags: review?(bernd_mozilla)
Assignee | ||
Comment 3•11 years ago
|
||
Make GetTableFrame() abort if the arg isn't a table frame descendant. Consequently, remove null-checks of GetTableFrame() results.
Attachment #586840 -
Flags: review?(bernd_mozilla)
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #586841 -
Flags: review?(bernd_mozilla)
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #586842 -
Flags: review?(bernd_mozilla)
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #586843 -
Flags: review?(bernd_mozilla)
Assignee | ||
Comment 7•11 years ago
|
||
Attachment #586844 -
Flags: review?(bernd_mozilla)
Comment 10•11 years ago
|
||
Comment on attachment 586835 [details] [diff] [review] Remove null-checks of GetFirstInFlow() result Review of attachment 586835 [details] [diff] [review]: ----------------------------------------------------------------- please remove also mxr.mozilla.org/mozilla-central/source/layout/tables/nsTableFrame.cpp#3311 it doubles http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsSplittableFrame.cpp#197 Further remove http://mxr.mozilla.org/mozilla-central/source/layout/tables/nsTableFrame.cpp#6237 http://mxr.mozilla.org/mozilla-central/source/layout/tables/nsTableFrame.cpp#6248 The patch is OK in itself, but lets get rid of it all once.
Attachment #586835 -
Flags: review?(bernd_mozilla) → review-
Assignee | ||
Comment 11•11 years ago
|
||
Hmm, yes, those changes got lost somehow... I took the opportunity of simplifying GetColumnWidth as well.
Attachment #586835 -
Attachment is obsolete: true
Attachment #588777 -
Flags: review?(bernd_mozilla)
Comment 12•11 years ago
|
||
Comment on attachment 588777 [details] [diff] [review] Remove null-checks of GetFirstInFlow() result Review of attachment 588777 [details] [diff] [review]: ----------------------------------------------------------------- thats what I wanted.
Attachment #588777 -
Flags: review?(bernd_mozilla) → review+
Comment 13•11 years ago
|
||
Comment on attachment 586836 [details] [diff] [review] Remove unnecessary nsTableFrame::GetFirstInFlow() calls to get IsBorderCollapse() bit Review of attachment 586836 [details] [diff] [review]: ----------------------------------------------------------------- yep the master himself was inconsistent with respect to this, http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/tables/nsTableRowGroupFrame.cpp&rev=3.411&mark=394#394
Attachment #586836 -
Flags: review?(bernd_mozilla) → review+
Comment 14•11 years ago
|
||
Comment on attachment 586840 [details] [diff] [review] Make nsTableFrame::GetTableFrame abort if the given frame isn't a table frame descendant Review of attachment 586840 [details] [diff] [review]: ----------------------------------------------------------------- I like the change to NS_RUNTIMEABORT("unable to find table parent");
Attachment #586840 -
Flags: review?(bernd_mozilla) → review+
Attachment #586841 -
Flags: review?(bernd_mozilla) → review+
Attachment #586842 -
Flags: review?(bernd_mozilla) → review+
Attachment #586843 -
Flags: review?(bernd_mozilla) → review+
Attachment #586844 -
Flags: review?(bernd_mozilla) → review+
Assignee | ||
Comment 15•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/57fc94d1196a https://hg.mozilla.org/integration/mozilla-inbound/rev/14223e7cfb3b https://hg.mozilla.org/integration/mozilla-inbound/rev/302fde3d16e3 https://hg.mozilla.org/integration/mozilla-inbound/rev/5ba6c4100885 https://hg.mozilla.org/integration/mozilla-inbound/rev/f0eeea7083ec https://hg.mozilla.org/integration/mozilla-inbound/rev/9d4556015326 https://hg.mozilla.org/integration/mozilla-inbound/rev/3077b729dfd5
Whiteboard: [inbound]
Target Milestone: --- → mozilla12
Comment 16•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/57fc94d1196a https://hg.mozilla.org/mozilla-central/rev/14223e7cfb3b https://hg.mozilla.org/mozilla-central/rev/302fde3d16e3 https://hg.mozilla.org/mozilla-central/rev/5ba6c4100885 https://hg.mozilla.org/mozilla-central/rev/f0eeea7083ec https://hg.mozilla.org/mozilla-central/rev/9d4556015326 https://hg.mozilla.org/mozilla-central/rev/3077b729dfd5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in
before you can comment on or make changes to this bug.
Description
•