Closed Bug 333289 Opened 16 years ago Closed 14 years ago
Kill All .js is not installed by make install
All is in the summary. See the (soon) attached patch.
Attachment #217717 - Flags: review?(stephenpmorse)
email@example.com does not seem to be an active account. Maybe another reviewer would be best?
well, i took the one who last submitted changes to the makefile there. who would be best for review on that one ?
Well, that was in 2002, by someone @netscape.com ;) neil@httl or jag@tty can probably give you r+sr for such a simple patch.
Attachment #217717 - Flags: review?(stephenpmorse) → review?(neil)
Comment on attachment 217717 [details] [diff] [review] Patch Looks good, although I don't think that clean rule is realistic, but I'll punt this to jag for his opinion.
Attachment #217717 - Flags: review?(neil) → review?(jag)
Comment on attachment 217717 [details] [diff] [review] Patch You can safely remove that clean:: section, all files under dist/ get removed for "free" 'coz of |GARBAGE_DIRS += dist| in /Makefile.in There are two more files which do the explicit delete, if you feel like cleaning up this one please do these two too: xpfe/components/resetPref/Makefile.in xpfe/components/updates/src/Makefile.in
Attachment #217717 - Flags: review?(jag) → review+
Was this patch here ever checked in?
Bug 348437 killed killAll. Bug no longer valid. ;)
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.