333289 - nsKillAll.js is not installed by make install

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

All is in the summary. See the (soon) attached patch.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

[e-mail] does not seem to be an active account. Maybe another reviewer would be best?

Comment 3

[Mike Hommey [:glandium]]

well, i took the one who last submitted changes to the makefile there. who would be best for review on that one ?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Well, that was in 2002, by someone @netscape.com ;)
neil@httl or jag@tty can probably give you r+sr for such a simple patch.

Comment 5

[[e-mail]]

Comment on attachment 217717 [details] [diff] [review]
Patch

Looks good, although I don't think that clean rule is realistic, but I'll punt this to jag for his opinion.

Comment 6

[jag (Peter Annema)]

Comment on attachment 217717 [details] [diff] [review]
Patch

You can safely remove that clean:: section, all files under dist/ get removed for "free" 'coz of |GARBAGE_DIRS += dist| in /Makefile.in

There are two more files which do the explicit delete, if you feel like cleaning up this one please do these two too:

xpfe/components/resetPref/Makefile.in
xpfe/components/updates/src/Makefile.in

Comment 7

[Frank Wein [:mcsmurf]]

Was this patch here ever checked in?

Comment 8

[Reed Loden [:reed]]

Bug 348437 killed killAll. Bug no longer valid. ;)