333374 - make advanced search work like it says in the spec

Status: RESOLVED DUPLICATE of bug 374530

(Firefox :: Bookmarks & History, defect, P3)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: partial work (includes other patches)

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

This patch (a first pass, does not do everything required) includes:

- various style tweaks to the query builder. 
- changes the functionality of the +/- buttons:
  - now means "remove this row" not "remove last row" 
  the + button on the header does not change to a - to hide the entire widget, rather it remains a + to allow for easy adding of terms, similar to the Finder add terms widget
- Fix a few bugs in the widget that were introduced when the maxRows went from 4 to 3.
- Add some more documentation to the areas of code that I touched!
- When the user removes all the rows, make it so that the search they did before opening the query builder is re-run
- When the user clicks on another item in the places list, make the query UI go away.

Also general places window hygeine:
- move commands that relate only to the organizer window out of commands.inc and into places.xul
- Make setHeader on PlacesOrganizer be a public method and define the different types explicitly

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

landed this patch on trunk and branch. more work to be done though.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

landed this patch on trunk and branch. more work to be done though.

Comment 5

[Tracy Walker [:tracy]]

I believe this is being tracked in the later Places bug 374530

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv