333420 - Can't build with gcj

Status: VERIFIED FIXED

(Core Graveyard :: Java to XPCOM Bridge, defect)

Description

[Mike Hommey [:glandium]]

When trying to build with gcj 4.0, I get the following error:

./../nsJavaXPCOMBindingUtils.cpp: In member function 'nsresult NativeToJavaProxyMap::Remove(JNIEnv*, nsISupports*, const nsIID&)':
./../nsJavaXPCOMBindingUtils.cpp:535: error: invalid conversion from '__jobject* const' to '__jweak*'
./../nsJavaXPCOMBindingUtils.cpp:535: error:   initializing argument 1 of 'void _Jv_JNIEnv::DeleteWeakGlobalRef(__jweak*)'

Comment 1

[jhp (no longer active)]

Attachment: patch

Odd that I don't get this error (or a warning even) on other compilers, since it is clearly going from a const to non-const situation.  Try this patch.

Comment 2

[Mike Hommey [:glandium]]

A bit different with the patch:
./../nsJavaXPCOMBindingUtils.cpp: In member function 'nsresult NativeToJavaProxyMap::Remove(JNIEnv*, nsISupports*, const nsIID&)':
./../nsJavaXPCOMBindingUtils.cpp:535: error: invalid conversion from '__jobject*' to '__jweak*'

(I am not authorized to edit the attachment, though i've been asked review to... bugzilla is... interesting...)

Comment 3

[Mike Hommey [:glandium]]

BTW, is there any simple way to test the javaxpcom stuff ? It seems the tests in extensions/java/xpcom/tests don't use the javaxpcomglue and javaxpcom.jar.

Comment 4

[jhp (no longer active)]

Attachment: patch v1.1

Forgot about the static cast;  was only doing const cast.  Give this a shot.

Comment 5

[Mike Hommey [:glandium]]

it builds fine, but i don't know how to test if it works correctly.

Comment 6

[jhp (no longer active)]

Checked in patch to trunk.  Marking as fixed for now, but if you have more problems, reopen the bug.

Also, I updated some of the TestArray and TestJavaProxy tests on the trunk (although TestArray seems to have some issues).  But those should be good enough to tell you if JavaXPCOM is working correctly.

Comment 7

[Mike Hommey [:glandium]]

I can confirm that the patch works correctly