333450 - Add index value for result nodes

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Brett Wilson]

Result nodes should have an integer field that we can use for indices in the case of bookmark queries, and priority values in the case of history queries. This will simplify some of the bookmark handling code and allows sorting by priority in the future.

Comment 1

[Brett Wilson]

Attachment: Patch

This adds the bookmarkIndex property to all result nodes. This is valid for all items inside bookmark folders. The sorting is also updated so that you can sort by bookmark index (no sorting) when viewing a folder.

I changed the way separators are handled. It used to be that separators were removed when folders are sorted. This new code allows the items to be sorted by index to reset, so we can't delete them. Instead, the tree view filters them out when it notices sorting is different.

I removed the OnItemMoved notification which I noticed is never called. Instead, the bookmarks service sends a remove and an add notification, which should be sufficient.

I also added a clarification in the comments for the favicon service.

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 218199 [details] [diff] [review]
Patch

r=[e-mail]

Comment 3

[Brett Wilson]

Fixed on branch and trunk.

Comment 4

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv