333479 - Make bookmarks.html not get copied into new profiles

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Brett Wilson]

Having this file is confusing and it shouldn't be there. People might mistaken it for their bookmarks and back it up instead of the real file.

Comment 1

[Dietrich Ayala (:dietrich)]

should just import directly from the default profile.

see also patch in bug 381365.

Comment 2

[[e-mail]]

But don't break upgrading old profiles!

Comment 3

[Michael Kohler [:mkohler]]

So we just delete the code for creating a bookmarks.html in a new profile and make sure to import the bookmarks.html from defProf when bookmarks.html doesn't exist?

Could somebody please assign me to this bug?

Comment 4

[Michael Kohler [:mkohler]]

We should just make sure bookmarks.html doesn't get copied from default profile folder, right?

Isn't this http://mxr.mozilla.org/mozilla-central/source/profile/dirserviceprovider/src/nsProfileDirServiceProvider.cpp#249 ? When I delete these lines (just that else if) and recompile it, it still creates a bookmarks.html when creating a new profile.

Comment 5

[Michael Kohler [:mkohler]]

New approach:

* Taking bookmarks.html out of "profDef" and put it into an other folder (which one?).
* So it wouldn't get copied, upgrading old profile wouldn't break.
* We check if there is a bookmarks.html in the profile folder, if so, we take this one for generate the sqlite. If not, we take the default bookmarks.html from the other folder (see * number 1)

How's this one?

Comment 6

[Marco Bonardo [:mak]]

we need to know what is copying it before taking any decision...

Comment 7

[Michael Kohler [:mkohler]]

> * So it wouldn't get copied, upgrading old profile wouldn't break.

"it wouldn't get copied" = the bookmarks.html file wouldn't get copied from "profDef" to the profile folder when creating a new profile. (sorry)

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 9

[Mark Banner (:standard8)]

I created a couple of new profiles today for some other testing. Neither of them has a bookmarks.html. Looks like this was probably fixed by bug 1235107 or maybe something even earlier.