333542 - GenerateJavaInterfaces doesn't need to be shipped

Status: RESOLVED WORKSFORME

(Core Graveyard :: Java to XPCOM Bridge, defect)

Description

[Mike Hommey [:glandium]]

GenerateJavaInterfaces is shipped in dist/bin (thus in tarballs), while it is pretty useless outside the build system.
It could just be used directly from its directory and not installed.
Patch to be attached

Comment 1

[Mike Hommey [:glandium]]

Attachment: Patch

Comment 2

[jhp (no longer active)]

Comment on attachment 217991 [details] [diff] [review]
Patch

Good catch.  I had originally intended for this tool to be more general, allowing a user to output a Java interface file for a given interface.  But after talking to bsmedberg, I decided to get xpidl working properly.  So, yes, this should not be installed in dist/bin.

Comment 3

[Mike Hommey [:glandium]]

Attachment: New patch

Oops, I forgot the most important : NO_DIST_INSTALL

Comment 4

[Mike Hommey [:glandium]]

Attachment: Final (?) patch

I forgot something else...

Comment 5

[Mike Hommey [:glandium]]

Attachment: This one might be the one

Comment 6

[Mike Hommey [:glandium]]

Maybe I should file another bug for that, but running GenerateJavaInterfaces has the side effect to create components/compreg.dat and components/xpti.dat in dist/bin. This may not be desired.

Comment 7

[jhp (no longer active)]

Comment on attachment 218136 [details] [diff] [review]
This one might be the one

I'm testing this patch, but it's not working for me.

First, .iface_done should no longer depend on the GenerateJavaInterfaces executable.  Previously, this dependency was on the exe in dist/bin (which was either a symlink, or a copy on Win32).  So it was either there or it wasn't, and you'd get a build break if it wasn't.

Now, because it depends on the one in tools/genifaces, I was getting the problem where it was trying to build the exe in xpcom/interfaces.  So that dependency should be removed.

Also, I'm getting errors when running GEnerateJavaInterfaces, such as "Could not write out perisistant registry!"  This is because GenerateJavaInterfaces is no longer running from inside the dist/bin directory;  its working path is different, causing problems.  In fact, the manifest file is listed as:
"Type Manifest File: /Users/pedemonte/builds/xulrunner/mozilla/objdbg/extensions/java/xpcom/interfaces/../../../../extensions/java/xpcom/tools/genifaces/components/xpti.dat".
  But that file should be in dist/bin/components.

Comment 8

[jhp (no longer active)]

On Linux and Mac OS X, we use the run-mozilla.sh script to set the environment up, before calling GenerateJavaInterfaces.  However, that script assumes that the exe is being run from dist/bin, so that's what is failing for me.

Win32 will also not work because GenerateJavaInterfaces.exe won't find the dependent libraries in dist/bin.

(In reply to comment #6)
> running GenerateJavaInterfaces has the side effect to create
> components/compreg.dat and components/xpti.dat in dist/bin.

This is necessary.  GenerateJavaInterfaces uses the nsIInterfaceInfoManager interface, and it makes use of these files.

Comment 9

[Mike Hommey [:glandium]]

(In reply to comment #7)
> (From update of attachment 218136 [details] [diff] [review] [edit])
> I'm testing this patch, but it's not working for me.
> 
> First, .iface_done should no longer depend on the GenerateJavaInterfaces
> executable.  Previously, this dependency was on the exe in dist/bin (which was
> either a symlink, or a copy on Win32).  So it was either there or it wasn't,
> and you'd get a build break if it wasn't.
> 
> Now, because it depends on the one in tools/genifaces, I was getting the
> problem where it was trying to build the exe in xpcom/interfaces.  So that
> dependency should be removed.
> 
> Also, I'm getting errors when running GEnerateJavaInterfaces, such as "Could
> not write out perisistant registry!"  This is because GenerateJavaInterfaces is
> no longer running from inside the dist/bin directory;  its working path is
> different, causing problems.  In fact, the manifest file is listed as:
> "Type Manifest File:
> /Users/pedemonte/builds/xulrunner/mozilla/objdbg/extensions/java/xpcom/interfaces/../../../../extensions/java/xpcom/tools/genifaces/components/xpti.dat".
>   But that file should be in dist/bin/components.
> 

Mmmmm I'll have to look into that, 'cause it worked perfectly well here... (Linux)

Comment 10

[Mike Hommey [:glandium]]

I was wondering. Isn't xpidl able to output the java interfaces from the idl files ?

Comment 11

[jhp (no longer active)]

The current xpidl has bad Java support.  I'm working to fix it in bug 333618.  Eventually, we'll use that instead of GenerateJavaInterfaces.

Comment 12

[jhp (no longer active)]

With the check in of bug 333618, GenerateJavaInterfaces is no longer built.