Key event not available on GTK2 warning (Switch Text Direction key)

RESOLVED FIXED

Status

Other Applications
ChatZilla
--
minor
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: sgautherie, Assigned: Gijs)

Tracking

Bug Flags:
blocking1.8.1 -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cz-0.9.78], URL)

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20060403 SeaMonkey/1.5a] (nightly) (W98SE)

{{
Warning: Key event not available on GTK2: key="e" modifiers="accel shift "
Source File: chrome://chatzilla/content/chatzilla.xul
Line: 0
}}

(See bug 311756 for the "same" issue in Core components)
(Assignee)

Comment 1

12 years ago
Fixing bogus summary, cz.xul has nothing to do with this.

CC-ing someone who actually uses this stuff - Eyal, what shortcut could we use instead? Is there a standard we could adhere to that we are not already using for other things?

(For the record, I think starting to preprocess any of our files just to squash this warning, and coming up with some other key just for GTK2 would be weird and inconsistent, so we can either ignore the warning or change it altogether, imho)
Flags: blocking1.8.1?
Summary: In <chatzilla.xul>, |Warning: Key event not available on GTK2: key="e" modifiers="accel shift "| → Key event not available on GTK2 warning (Switch Text Direction key)

Comment 2

12 years ago
Accel+Shift+X is the standard key combo for Switch Text Direction in Mozilla (bug 251958). I think we should add that as the primary shortcut (shown on menus, in docs, etc.), and maybe keep the old shortcut. From what I've read, the warning can be suppressed by putting an extra comma at the beginning of the modifiers.

Comment 3

12 years ago
Ok, so WHY is this shortcut not available? And why has the "standard" switch text direction key changed since we added it? Who didn't tell us when they changed?

Updated

12 years ago
OS: Windows 98 → All
Hardware: PC → All
not a blocker at this point, its just a warning, Chatzilla can decide how they want to handle this.
Flags: blocking1.8.1? → blocking1.8.1-
(Assignee)

Comment 5

11 years ago
Created attachment 245831 [details] [diff] [review]
Just use the new shortcut

OK, I agree we should have been told and all that, but I'm not about to go on a crusade just because someone forgot to tell us. Let's just fix this and move on, it's no use keeping a bug around for month if there's a 2-line patch way to solve it.
Assignee: rginda → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #245831 - Flags: review?(samuel)

Comment 6

11 years ago
Comment on attachment 245831 [details] [diff] [review]
Just use the new shortcut

What he said!
Attachment #245831 - Flags: review?(samuel) → review+
(Assignee)

Comment 7

11 years ago
Checking in mozilla/extensions/irc/xul/locale/en-US/chatzilla.properties;
/cvsroot/mozilla/extensions/irc/xul/locale/en-US/chatzilla.properties,v  <--  chatzilla.properties
new revision: 1.126; previous revision: 1.125
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

11 years ago
(This warning feature does not exist on 1.8 branch;
I can't test Trunk builds anymore (on W98SE).)

Updated

11 years ago
Whiteboard: [cz-0.9.78]
You need to log in before you can comment on or make changes to this bug.