333570 - Key event not available on GTK2 warning (Switch Text Direction key)

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20060403 SeaMonkey/1.5a] (nightly) (W98SE)

{{
Warning: Key event not available on GTK2: key="e" modifiers="accel shift "
Source File: chrome://chatzilla/content/chatzilla.xul
Line: 0
}}

(See bug 311756 for the "same" issue in Core components)

Comment 1

[:Gijs (he/him)]

Fixing bogus summary, cz.xul has nothing to do with this.

CC-ing someone who actually uses this stuff - Eyal, what shortcut could we use instead? Is there a standard we could adhere to that we are not already using for other things?

(For the record, I think starting to preprocess any of our files just to squash this warning, and coming up with some other key just for GTK2 would be weird and inconsistent, so we can either ignore the warning or change it altogether, imho)

Comment 2

[Rob Marshall [tH]]

Accel+Shift+X is the standard key combo for Switch Text Direction in Mozilla (bug 251958). I think we should add that as the primary shortcut (shown on menus, in docs, etc.), and maybe keep the old shortcut. From what I've read, the warning can be suppressed by putting an extra comma at the beginning of the modifiers.

Comment 3

[James Ross]

Ok, so WHY is this shortcut not available? And why has the "standard" switch text direction key changed since we added it? Who didn't tell us when they changed?

Comment 4

[Mike Connor [:mconnor]]

not a blocker at this point, its just a warning, Chatzilla can decide how they want to handle this.

Comment 5

[:Gijs (he/him)]

Attachment: Just use the new shortcut

OK, I agree we should have been told and all that, but I'm not about to go on a crusade just because someone forgot to tell us. Let's just fix this and move on, it's no use keeping a bug around for month if there's a 2-line patch way to solve it.

Comment 6

[James Ross]

Comment on attachment 245831 [details] [diff] [review]
Just use the new shortcut

What he said!

Comment 7

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/xul/locale/en-US/chatzilla.properties;
/cvsroot/mozilla/extensions/irc/xul/locale/en-US/chatzilla.properties,v  <--  chatzilla.properties
new revision: 1.126; previous revision: 1.125
done

Comment 8

[Serge Gautherie (:sgautherie)]

(This warning feature does not exist on 1.8 branch;
I can't test Trunk builds anymore (on W98SE).)