Last Comment Bug 333570 - Key event not available on GTK2 warning (Switch Text Direction key)
: Key event not available on GTK2 warning (Switch Text Direction key)
Status: RESOLVED FIXED
[cz-0.9.78]
:
Product: Other Applications
Classification: Client Software
Component: ChatZilla (show other bugs)
: Trunk
: All All
: -- minor with 1 vote (vote)
: ---
Assigned To: :Gijs Kruitbosch (away 26-29 incl.)
: Samuel Sieb
Mentors:
http://bonsai.mozilla.org/cvsblame.cg...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-04-11 03:12 PDT by Serge Gautherie (:sgautherie)
Modified: 2006-12-08 04:37 PST (History)
6 users (show)
mconnor: blocking1.8.1-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Just use the new shortcut (1.08 KB, patch)
2006-11-17 03:37 PST, :Gijs Kruitbosch (away 26-29 incl.)
bugzilla-mozilla-20000923: review+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2006-04-11 03:12:23 PDT
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20060403 SeaMonkey/1.5a] (nightly) (W98SE)

{{
Warning: Key event not available on GTK2: key="e" modifiers="accel shift "
Source File: chrome://chatzilla/content/chatzilla.xul
Line: 0
}}

(See bug 311756 for the "same" issue in Core components)
Comment 1 :Gijs Kruitbosch (away 26-29 incl.) 2006-04-11 04:54:43 PDT
Fixing bogus summary, cz.xul has nothing to do with this.

CC-ing someone who actually uses this stuff - Eyal, what shortcut could we use instead? Is there a standard we could adhere to that we are not already using for other things?

(For the record, I think starting to preprocess any of our files just to squash this warning, and coming up with some other key just for GTK2 would be weird and inconsistent, so we can either ignore the warning or change it altogether, imho)
Comment 2 Rob Marshall [tH] 2006-04-11 06:24:14 PDT
Accel+Shift+X is the standard key combo for Switch Text Direction in Mozilla (bug 251958). I think we should add that as the primary shortcut (shown on menus, in docs, etc.), and maybe keep the old shortcut. From what I've read, the warning can be suppressed by putting an extra comma at the beginning of the modifiers.
Comment 3 James Ross 2006-04-11 08:25:59 PDT
Ok, so WHY is this shortcut not available? And why has the "standard" switch text direction key changed since we added it? Who didn't tell us when they changed?
Comment 4 Mike Connor [:mconnor] 2006-06-21 10:59:27 PDT
not a blocker at this point, its just a warning, Chatzilla can decide how they want to handle this.
Comment 5 :Gijs Kruitbosch (away 26-29 incl.) 2006-11-17 03:37:15 PST
Created attachment 245831 [details] [diff] [review]
Just use the new shortcut

OK, I agree we should have been told and all that, but I'm not about to go on a crusade just because someone forgot to tell us. Let's just fix this and move on, it's no use keeping a bug around for month if there's a 2-line patch way to solve it.
Comment 6 James Ross 2006-11-27 15:05:09 PST
Comment on attachment 245831 [details] [diff] [review]
Just use the new shortcut

What he said!
Comment 7 :Gijs Kruitbosch (away 26-29 incl.) 2006-11-28 15:05:55 PST
Checking in mozilla/extensions/irc/xul/locale/en-US/chatzilla.properties;
/cvsroot/mozilla/extensions/irc/xul/locale/en-US/chatzilla.properties,v  <--  chatzilla.properties
new revision: 1.126; previous revision: 1.125
done
Comment 8 Serge Gautherie (:sgautherie) 2006-11-29 12:01:50 PST
(This warning feature does not exist on 1.8 branch;
I can't test Trunk builds anymore (on W98SE).)

Note You need to log in before you can comment on or make changes to this bug.