333600 - ssltap should format and display TLS hello extensions and alerts

Status: RESOLVED FIXED

(NSS :: Tools, enhancement, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

Several TLS hello extensions are being added to NSS for NSS 3.11.1
ssltap should be able to display them properly.
P2

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

The same RFC that defines new hello extensions also defines new alerts.
The implementation of this RFE must include implementation of those alerts.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Attachment: parse/format extensions

Taking.  This patch needs more testing before I ask for review.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Attachment: debugged patch

Alexei, please reivew.  Note that this patch also includes 
the patch for bug 334314, which you have already reviewed.
I hope you don't mind it appearing twice.

Comment 4

[Alexei Volkov]

Comment on attachment 218729 [details] [diff] [review]
debugged patch

Looks good and works well.

Miner:
Not every occurrence of PR_fprintf(PR_STDOUT, x )
is substituted to PR_FPUTS. 

Nice finding of param%1 for calculating odd value.

should the warning be issued if pos >= length in the while loop of print_hello_extention?

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Checked in on trunk and branch.
Checking in ssltap.c; new revision: 1.8;     previous revision: 1.7
Checking in ssltap.c; new revision: 1.7.2.1; previous revision: 1.7