333712 - new icons for trunk builds based on minefield icon

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

Bug 308973 renamed trunk builds to "Minefield" and in bug 330533 sgarrity provided a cute new graphic that visually represents the expected stability of trunk builds. I'm not sure that we want to, but it might be cute to use that graphic as the shortcut icon as well.

This would require changing the .ico and png files in /browser/app, if I'm reading the build code correctly.

Comment 1

[Steven Garrity [:sgarrity]]

Attachment: Windows icon for Minefield

Comment 2

[Steven Garrity [:sgarrity]]

Attachment: Mac OS X icon for Minefield

Comment 3

[Steven Garrity [:sgarrity]]

Attachment: PNG Version of Minefield icon

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

I ran a build and confirmed that this works for OSX, at least (http://beltzner.ca/webdav/minefield.app.png) I *think* they need to be checked in as ..:

windows icon   ----> /browser/app/firefox.ico
PNG icon (gtk) ----> /browser/app/mozicon128.png
OS X icon ---------> /browser/app/macbuild/firefox.icns

(cc'ing bsmedberg and mconnor as they might know for sure)

Comment 5

[Andreas Grillenberger]

Yes, they need to be checked in this way.

Perhaps adequate document icons would be nice, too?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Checked these in on the trunk.
mozilla/browser/app/macbuild/firefox.icns 	1.3
mozilla/browser/app/mozicon128.png 	1.2
mozilla/browser/app/firefox.ico 	1.3

Comment 7

[pal-moz]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060413 Firefox/3.0a1 ID:2006041403 [cairo]

fixed?
screen shot : http://img135.imageshack.us/img135/5832/aaa3ig.jpg

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Gavin, can you verify this on windows? That screenshot makes it look very much unfixed ... I can verify that the checkin makes it work on OSX.

Comment 9

[Andreas Grillenberger]

At mine the icon is right - in own builds, in tinderbox builds and in the official nightly builds.
Screenshot: http://img454.imageshack.us/my.php?image=icon2gn.png

Comment 10

[Jesse Ruderman]

The bomb icon looks a bit off-center in the Mac OS X dock.  I mentioned this to Mike Beltzner and he said "I think the best way to resolve that would be to shrink it a bit more and pad it out with some empty space on the right side to offset the dynamite stick coming out of the left."

Comment 11

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #8)
> Gavin, can you verify this on windows? That screenshot makes it look very much
> unfixed ... I can verify that the checkin makes it work on OSX.

The correct icon appears on windows, using the latest windows nightly. The dynamite is kind of hard to see on a white background (windows explorer) and even as the window icon (16x16), but it's there.

Comment 12

[Daniel C]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060417 Firefox/3.0a1

On Linux, the icon is still the plain globe. In the firefox/icons/ directory I see a plain document.png, mozicon16.xpm and mozicon50.xpm. Only mozicon128.png has the new graphic. Can these 3 files be updated too?

http://lxr.mozilla.org/mozilla/source/browser/app/document.png
http://lxr.mozilla.org/mozilla/source/browser/app/mozicon16.xpm
http://lxr.mozilla.org/mozilla/source/browser/app/mozicon50.xpm

http://lxr.mozilla.org/mozilla/source/browser/app/default.xpm is also the plain icon.

I'm also not sure why http://lxr.mozilla.org/mozilla/source/browser/base/branding/icon64.png still exists.

Reopening to fix Linux icon issue.

Comment 13

[Steven Garrity [:sgarrity]]

Is this still an issue - will the bomb icon be used for nightly-builds indefinitely?

Comment 14

[Michael Morgan [:morgamic]]

Alex, could you give us some help with this and/or point us in a direction?

Comment 15

[Mike Connor [:mconnor]]

We don't use XPM anymore, we use the pngs at https://bugzilla.mozilla.org/show_bug.cgi?id=495250 now.  

bug 495250 covers adding the 22/24/256 sizes that GNOME would like, but we have 16/32/48 now.