333855 - Ctrl+J as a shortcut to invoke download manager

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, enhancement)

Description

[Alan]

It would be nice if Ctrl+J was available for the Mozilla download manager, to match Firefox as it is sometimes convenient to have.  (Ctrl+J doesn't seem to have been used by Mozilla for anything else)

Comment 1

[zug_treno]

Attachment: Diff made with Patch Maker and SeaMonkey 1.5a/20060714

Ctrl+j should open the download manager with this patch.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 229395 [details] [diff] [review]
Diff made with Patch Maker and SeaMonkey 1.5a/20060714

I'm not really the right person for changes like this

Comment 3

[[e-mail]]

Comment on attachment 229395 [details] [diff] [review]
Diff made with Patch Maker and SeaMonkey 1.5a/20060714

Switch downloadManagerKb to key_downloadManager ?

Comment 4

[zug_treno]

Attachment: Second diff made with Patch Maker and SeaMonkey 1.5a/20060714

(In reply to comment #3)
> Switch downloadManagerKb to key_downloadManager ?

Yes you're right, it seems that key_... is used (much) more often than ...Kb so I changed the id to key_downloadManager.

Comment 5

[zug_treno]

I realize i'm a bit late with this, but could somebody check this in on the trunk (and maybe the 1.1 branch)?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

I would check this in, but I'm not sure which files this should be patching in CVS (I'm guessing suite/common/tasksOverlay.xul and suite/locales/en-US/chrome/common/tasksOverlay.dtd).

Comment 7

[zug_treno]

(In reply to comment #6)
> I would check this in, but I'm not sure which files this should be patching in
> CVS (I'm guessing suite/common/tasksOverlay.xul and
> suite/locales/en-US/chrome/common/tasksOverlay.dtd).

I'm not sure either, /suite/common/tasksOverlay.xul and /xpfe/communicator/resources/content/tasksOverlay.xul seem to be identical so maybe both files should be patched?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Removing [checkin needed] until comment 7 is addressed...

Comment 9

[Krang]

(In reply to comment #7)
> I'm not sure either, /suite/common/tasksOverlay.xul and
> /xpfe/communicator/resources/content/tasksOverlay.xul seem to be identical so
> maybe both files should be patched?

When I wrote a SeaMonkey patch a couple of months ago, it was applied to both the suite/ and xpfe/ directories, so I think you're right.  See bug 133117 comment 43.

Comment 10

[Robert Kaiser]

Neil, do we still want this, and if so, does this still apply in some sane way? If so, we should try to get it in, else we should resolve the bug otherwise.

Comment 11

[[e-mail]]

Attachment: zug_treno's patch updated for major bitrot [Checkin: Comment 12]

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 393153 [details] [diff] [review]
zug_treno's patch updated for major bitrot
[Checkin: Comment 12]


http://hg.mozilla.org/comm-central/rev/d24871402e6f

Comment 13

[Sander]

This shortcut clashes with chatzilla's "join channel". I've filed bug 546380 proposing to change the shortcut to something else.