Ctrl+J as a shortcut to invoke download manager

RESOLVED FIXED in seamonkey2.0b2

Status

SeaMonkey
Download & File Handling
--
enhancement
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: Alan, Assigned: zug_treno)

Tracking

Trunk
seamonkey2.0b2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

11 years ago
It would be nice if Ctrl+J was available for the Mozilla download manager, to match Firefox as it is sometimes convenient to have.  (Ctrl+J doesn't seem to have been used by Mozilla for anything else)
Summary: Ctrl+J for download manager → Ctrl+J as a shortcut to invoke download manager
(Assignee)

Comment 1

11 years ago
Created attachment 229395 [details] [diff] [review]
Diff made with Patch Maker and SeaMonkey 1.5a/20060714

Ctrl+j should open the download manager with this patch.
Attachment #229395 - Flags: superreview?(neil)
Attachment #229395 - Flags: review?
(Assignee)

Updated

11 years ago
Attachment #229395 - Flags: review? → review?(cbiesinger)
Comment on attachment 229395 [details] [diff] [review]
Diff made with Patch Maker and SeaMonkey 1.5a/20060714

I'm not really the right person for changes like this
Attachment #229395 - Flags: review?(cbiesinger) → review?(jag)

Comment 3

11 years ago
Comment on attachment 229395 [details] [diff] [review]
Diff made with Patch Maker and SeaMonkey 1.5a/20060714

Switch downloadManagerKb to key_downloadManager ?
Attachment #229395 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 4

11 years ago
Created attachment 229407 [details] [diff] [review]
Second diff made with Patch Maker and SeaMonkey 1.5a/20060714

(In reply to comment #3)
> Switch downloadManagerKb to key_downloadManager ?

Yes you're right, it seems that key_... is used (much) more often than ...Kb so I changed the id to key_downloadManager.
Attachment #229395 - Attachment is obsolete: true
Attachment #229407 - Flags: superreview?(neil)
Attachment #229407 - Flags: review?
Attachment #229395 - Flags: review?(jag)
(Assignee)

Updated

11 years ago
Attachment #229407 - Flags: review? → review?(jag)

Updated

11 years ago
Attachment #229407 - Flags: superreview?(neil) → superreview+

Updated

11 years ago
Attachment #229407 - Flags: review?(jag) → review+
(Assignee)

Comment 5

11 years ago
I realize i'm a bit late with this, but could somebody check this in on the trunk (and maybe the 1.1 branch)?
(Assignee)

Updated

11 years ago
Whiteboard: [checkin needed]
Assignee: download-manager → zug_treno
I would check this in, but I'm not sure which files this should be patching in CVS (I'm guessing suite/common/tasksOverlay.xul and suite/locales/en-US/chrome/common/tasksOverlay.dtd).
(Assignee)

Comment 7

11 years ago
(In reply to comment #6)
> I would check this in, but I'm not sure which files this should be patching in
> CVS (I'm guessing suite/common/tasksOverlay.xul and
> suite/locales/en-US/chrome/common/tasksOverlay.dtd).

I'm not sure either, /suite/common/tasksOverlay.xul and /xpfe/communicator/resources/content/tasksOverlay.xul seem to be identical so maybe both files should be patched?
Removing [checkin needed] until comment 7 is addressed...
Whiteboard: [checkin needed]

Comment 9

11 years ago
(In reply to comment #7)
> I'm not sure either, /suite/common/tasksOverlay.xul and
> /xpfe/communicator/resources/content/tasksOverlay.xul seem to be identical so
> maybe both files should be patched?

When I wrote a SeaMonkey patch a couple of months ago, it was applied to both the suite/ and xpfe/ directories, so I think you're right.  See bug 133117 comment 43.

Comment 10

8 years ago
Neil, do we still want this, and if so, does this still apply in some sane way? If so, we should try to get it in, else we should resolve the bug otherwise.
Created attachment 393153 [details] [diff] [review]
zug_treno's patch updated for major bitrot
[Checkin: Comment 12]

Updated

8 years ago
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment on attachment 393153 [details] [diff] [review]
zug_treno's patch updated for major bitrot
[Checkin: Comment 12]


http://hg.mozilla.org/comm-central/rev/d24871402e6f
Attachment #393153 - Attachment description: zug_treno's patch updated for major bitrot → zug_treno's patch updated for major bitrot [Checkin: Comment 12]
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed, uiwanted
QA Contact: download
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b2
Version: unspecified → Trunk
Attachment #229407 - Attachment is obsolete: true

Updated

8 years ago
Blocks: 509564

Comment 13

8 years ago
This shortcut clashes with chatzilla's "join channel". I've filed bug 546380 proposing to change the shortcut to something else.
You need to log in before you can comment on or make changes to this bug.