Closed
Bug 334070
Opened 19 years ago
Closed 19 years ago
Views don't care about mBatchCount!
Categories
(Calendar :: Internal Components, defect)
Calendar
Internal Components
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jminta, Assigned: jminta)
Details
Attachments
(1 file)
|
5.05 KB,
patch
|
dmosedale
:
first-review+
|
Details | Diff | Splinter Review |
http://landfill.mozilla.org/mxr-test/mozilla/search?string=mBatchCount&find=calendar&filter=
Views keep track of batches, but don't ignore changes that happen during them. Patch to follow
|
Assignee | |
Comment 1•19 years ago
|
||
Extremely low risk/high reward patch. Import should be much faster now. I'm almost inclined to take this for 0.3a2 even.
|
||
Comment 2•19 years ago
|
||
Comment on attachment 218486 [details] [diff] [review]
check for mBatchCount
r=dmose; this looks great! The only risk w.r.t. taking this for 0.3a2 that I can think of is if there's some way that an onEndBatch() call could inadvertantly not happen.
Attachment #218486 -
Flags: first-review?(dmose) → first-review+
|
||
Updated•19 years ago
|
Whiteboard: [needs landing]
|
||
Comment 3•19 years ago
|
||
Patch checked in on trunk and MOZILLA_1_8_BRANCH
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in
before you can comment on or make changes to this bug.
Description
•