Closed Bug 334070 Opened 14 years ago Closed 14 years ago

Views don't care about mBatchCount!

Categories

(Calendar :: Internal Components, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jminta, Assigned: jminta)

Details

Attachments

(1 file)

http://landfill.mozilla.org/mxr-test/mozilla/search?string=mBatchCount&find=calendar&filter=

Views keep track of batches, but don't ignore changes that happen during them.  Patch to follow
Extremely low risk/high reward patch.  Import should be much faster now.  I'm almost inclined to take this for 0.3a2 even.
Assignee: base → jminta
Status: NEW → ASSIGNED
Attachment #218486 - Flags: first-review?(dmose)
Comment on attachment 218486 [details] [diff] [review]
check for mBatchCount

r=dmose; this looks great!  The only risk w.r.t. taking this for 0.3a2 that I can think of is if there's some way that an onEndBatch() call could inadvertantly not happen.
Attachment #218486 - Flags: first-review?(dmose) → first-review+
Whiteboard: [needs landing]
Patch checked in on trunk and MOZILLA_1_8_BRANCH
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in before you can comment on or make changes to this bug.