334264 - text color in about dialog and time picker is not default color

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Damian Szczepanik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2

I switch Windows to some specific theme (see attachment) and open about dialog. Text is not visible, only links at the end of credits

Reproducible: Always

Steps to Reproduce:
1. adjust (Windows OS only) inverse theme
2. open about - dialog
3. switch to credits

Actual Results:  
text is not visible, text color = background color

Expected Results:  
text color should be visible like in about dialog (first "splash")

applicable: Windows OS

Comment 1

[Damian Szczepanik]

version: nightly/2006-04-10-08-trunk/sunbird-0.3a1+.en-US.win32.zip

Comment 2

[Damian Szczepanik]

Attachment: screenshot

Comment 3

[Damian Szczepanik]

Attachment: Theme

adjust this theme before tring to reproduce (WinXP, polish)

Comment 4

[Patrick Spendrin]

I will take over this bug. Patrick Spendrin

Comment 5

[Damian Szczepanik]

Attachment: screenshot: minutes

the same effect with minutes-chooser
I attach this defect here, because scenario is the same
I check out rest components and they looks good

Comment 6

[Matthew (lilmatt) Willis]

Not going to make the 0.3 train.

Comment 7

[Matthew (lilmatt) Willis]

Not going to make the 0.5 train.

Comment 9

[Simon Paquet [:sipaq]]

Attachment: Patch v1

Comment 10

[Simon Paquet [:sipaq]]

Attachment: 2nd patch - also addresses the problem in the minutes box

Comment 11

[Joey Minta]

Comment on attachment 260157 [details] [diff] [review]
2nd patch - also addresses the problem in the minutes box

       html {
         background-color: white;
+        color: black;
       }
Is this the kind of change that needs to be migrated to other apps too? Or are they already doing it?

Comment 12

[Simon Paquet [:sipaq]]

(In reply to comment #11)
> Is this the kind of change that needs to be migrated to other apps too? Or are
> they already doing it?

That is the proposed change for Firefox (see bug 374157). It would also be the proposed change for Thunderbird (see bug 375908), but both bugs don't have patches at the moment.

Comment 13

[Joey Minta]

Comment on attachment 260157 [details] [diff] [review]
2nd patch - also addresses the problem in the minutes box

r=jminta.  Bonus points if you fix the other apps. :-)

Comment 14

[Simon Paquet [:sipaq]]

Fix checked in

Comment 15

[Omar Bajraszewski]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5pre) Gecko/20070630 Calendar/0.7pre

Comment 16

[Stefan Sitter [:ssitter]]

Verified using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.5pre) Gecko/20070701 Calendar/0.7pre and a high contrast white on black theme.

Comment 17

[Damian Szczepanik]

REOPEN, does not work with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5pre) Gecko/20070707 Calendar/0.7pre

Comment 18

[Stefan Sitter [:ssitter]]

(In reply to comment #17)
Please specify "does not work". This was verified for Windows with the 20070630 build. What checkin regressed it?

Comment 19

[Stefan Sitter [:ssitter]]

Attachment: screenshot in Sunbird 0.7pre

This is how it looks using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.5pre) Gecko/20070708 Calendar/0.7pre. The text is now visible and the Expected Results are fulfilled -> fixed.

Comment 20

[Damian Szczepanik]

for this theme I would expect that background is black and text is white, right now is the opposite but if this was an intenstion, please close it (I see the same as #comment 19)

Comment 21

[Simon Paquet [:sipaq]]

This is done by intention, because otherwise the dialog would look sucky.