334437 - Crash and asserts when clicking on context-menu items places history [@ nsVoidArray::IndexOf]

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect, P2)

Description

[Ria Klaassen (not reading all bugmail)]

Steps to reproduce:
1. Open Places, right-click on a history-item and choose Delete
2. Result: the history-item is deleted like expected
3. Now rightclick on another history-item and choose Open
3. It opens, like expected
4. On the same item, choose Cut, or Copy
5. An assert appears
6. Choose Delete 
7. Firefox crashes

Contents assert:

ASSERT: null node
Stack Trace:
0:PC_nodeIsFolder(null)
1:PC_wrapNode[xpconnect wrapped nsINavHistoryResultNode],text/x-moz-place)
2:generateChunk(text/x-moz-place)
3:()
4:()
5:oncommand([objectMouseEvent])

This worked well in 1.9a1_2006041720 but got problematic in 1.9a1_2006041722.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Regression range is wrong, must be:
1.9a1_2006041313 - 1.9a1_2006041321.
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-04-13+12%3A00&maxdate=2006-04-13+21%3A00
which is the same as in Bug 334451.

Comment 2

[Ria Klaassen (not reading all bugmail)]

Talkbacks from the yesterday's nightly: 
TB17682090E  TB17682129W  TB17682247W

Incident ID: 17682090
Stack Signature	nsVoidArray::IndexOf fca0e75c
Product ID	FirefoxTrunk
Build ID	2006041705
Trigger Time	2006-04-18 04:39:35.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	xpcom_core.dll + (00003a1a)
URL visited	
User Comments	
Since Last Crash	46 sec
Total Uptime	28759 sec
Trigger Reason	Access violation
Source File, Line No.	c:\builds\tinderbox\fx-trunk-cairo\winnt_5.2_depend\mozilla\xpcom\build\nsvoidarray.cpp, line 380
Stack Trace 	
nsVoidArray::IndexOf   nsNavHistoryResult::OnDeleteURI   nsNavHistory::RemovePage   XPTC_InvokeByIndex   XPCWrappedNative::CallMethod    

Comment 3

[Marco Bonardo [:mak]]

this cannot be reproduced on current trunk. 
Ria, do you have an updated test case? those files have changed a lot

Comment 4

[Ria Klaassen (not reading all bugmail)]

No, this was a bug in the former places window which doesn't exist anymore.
I apparently forgot to close this one.

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv